Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plugins that still need a log4j version bump. #1387

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 20, 2021

Signed-off-by: dblock [email protected]

Description

Coming from opensearch-project/sql#345, remove the plugins that haven't had the version bump for log4j to get a 1.2.3-SNAPSHOT with opensearch-project/OpenSearch#1774.

Running ./build.sh manifests/1.2.3/opensearch-1.2.3.yml --snapshot passes with this change.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested a review from a team as a code owner December 20, 2021 20:16
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #1387 (1235dfd) into main (276f2c8) will decrease coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1387      +/-   ##
============================================
- Coverage     94.57%   94.02%   -0.55%     
- Complexity        0       11      +11     
============================================
  Files           119      138      +19     
  Lines          2930     3013      +83     
  Branches          0        8       +8     
============================================
+ Hits           2771     2833      +62     
- Misses          159      172      +13     
- Partials          0        8       +8     
Impacted Files Coverage Δ
tests/jenkins/jobs/PromoteArtifacts_Jenkinsfile 100.00% <0.00%> (ø)
tests/jenkins/jobs/BuildArchive_Jenkinsfile 100.00% <0.00%> (ø)
src/jenkins/Messages.groovy 68.42% <0.00%> (ø)
tests/jenkins/jobs/GetManifestSHA_Jenkinsfile 100.00% <0.00%> (ø)
src/jenkins/InputManifest.groovy 62.06% <0.00%> (ø)
tests/jenkins/jobs/AssembleUpload_Jenkinsfile 100.00% <0.00%> (ø)
.../jenkins/jobs/PromoteArtifacts_actions_Jenkinsfile 100.00% <0.00%> (ø)
tests/jenkins/jobs/BuildAssembleUpload_Jenkinsfile 100.00% <0.00%> (ø)
tests/jenkins/jobs/BuildDockerImage_Jenkinsfile 100.00% <0.00%> (ø)
src/jenkins/BuildManifest.groovy 73.33% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 276f2c8...1235dfd. Read the comment docs.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is for building maven for 1.2.3 snapshots right?

@dblock dblock merged commit ad157de into opensearch-project:main Dec 20, 2021
@dblock dblock deleted the remove-plugins branch December 20, 2021 21:47
dblock added a commit that referenced this pull request Dec 21, 2021
dblock added a commit to dblock/opensearch-build that referenced this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants