-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Version bump PR for functional test repo failed to update pack-lock.json #4638
Comments
Hey @zelinh that is done on purpose as AFAIK for FT repo we dont |
Yeah; we shouldn't need to bump it but it could help with tracking if we ever need to do so (which we have never needed to). |
Do we have a consensus on whether it should or should not be included? @AMoo-Miki |
Thinking about it more, we should keep the versions in the lock file and the manifest in sync. |
There is some discussion in past #3856 related to
Thank you |
The package-lock.json is not being updated currently check here. Do we still need to automate this? |
Describe the bug
The auto-generated version bump PR for functional test repo didn't include
package-lock.json
file.e.g. opensearch-project/opensearch-dashboards-functional-test#1216
It should have increment the version in
package-lock.json
here https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/45396abd554474e1eca18f20bb77bf42ee11fafa/package-lock.json#L3along with
package.json
.Seems like we missed it here.
opensearch-build/.github/workflows/osd-increment-plugin-versions.yml
Lines 95 to 99 in 90352da
To reproduce
Run the current GHA
Increment OpenSearch Dashboards Plugins Version
Expected behavior
All two json files should have version incremented.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: