-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[On-boarding]: dashboards-assistant plugin #4322
Comments
Hi @joshuali925 , Were you able to build the distribution using this new plugin? Steps are mentioned in the on-boarding document.
Thanks! |
Hi, In order to release this plugin as a part of the distribution, please make sure to onboard to distribution test workflow. See details here: https://github.com/opensearch-project/opensearch-build/wiki/Testing-the-Distribution Thanks! |
@joshuali925 This plugin will not be included in to distribution build if it doesn't contain the test workflows. CC: @prudhvigodithi |
thanks for the notice. I assume test workflow for dashboards plugins means cypress integration tests in the functional test repo? The onboarding doc section for testing seems only covered opensearch but not dashboards. please correct me if i'm wrong, thanks opensearch-build/ONBOARDING.md Line 40 in 31cc1ef
I believe for dashboards we moved to functional-test repo, the integration tests shouldn't be in the plugin directory? opensearch-build/ONBOARDING.md Line 46 in 31cc1ef
Are there backwards compatibility tests for dashboards? @ruanyl @SuZhou-Joe Does your team have bandwidth to add integration tests for dashboards-assistant to functional test repo? |
Hi @joshuali925 , Right! For dashboard plugins functional-test is the right place. We will add more details to the boarding document. The test workflow in this repository will run tests from functional test repo for all dashboards plugins under the hood. |
@joshuali925 We will working on adding and setting up functional tests in https://github.com/opensearch-project/opensearch-dashboards-functional-test |
The PR opensearch-project/opensearch-dashboards-functional-test#1002 and opensearch-project/opensearch-dashboards-functional-test#1005 to setup assistant test in FT repo has been merged. I have created a PR #4363 to on board assistant to 2.12.0 manifest and test workflow. Please take a look. |
Already onboarded, thanks. |
What is the name of your plugin?
dashboards-assistant
What is the link to your GitHub repo?
https://github.com/opensearch-project/dashboards-assistant/
Targeted release version
2.12.0
What type of the plugin are we on-boarding?
OpenSearch-dashboards plugin
Did you read the on-boarding document
yes
Does this plugin has all the necessary automated tests?
no IT yet. BWC not required
Have you completed the required reviews including Security reviews, UX reviews?
yes
Have you on-boarded automated security scanning for the GitHub repo associated with this plugin?
yes
Additional context
No response
The text was updated successfully, but these errors were encountered: