You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of now, if there is a version bump in nodejs for OSD core, the developer needs to update these values in dockerfile and ami template so that the images/amis can be rebuild.
The above is understandable as we do not want to use older version of node to build OSD and its plugins, even if they are compatible with lower versions defined by this PR:
[Triage]
Need a solution to fetch the node version from the Dashboard repo during the docker build, this way a manual PR is not required every time a new version is added. @peterzhuamazon
As of now, if there is a version bump in nodejs for OSD core, the developer needs to update these values in dockerfile and ami template so that the images/amis can be rebuild.
The above is understandable as we do not want to use older version of node to build OSD and its plugins, even if they are compatible with lower versions defined by this PR:
^14.20.1
and bump.nvmrc
tov14.21.3
OpenSearch-Dashboards#3463However, the current switching of the node version is not ideal, as it uses the .nvmrc value to switch version, and sometimes if the images are not bundled with the requested version, the build fail:
1116d3b#diff-764d0f380e0ea7d984b96da62499e5bb1c9ad946ef6834fede55159c7dc13366
https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-build-opensearch-dashboards/detail/distribution-build-opensearch-dashboards/5794/pipeline/165
In discussing with @AMoo-Miki we note that node version change is going to be rapid later on in order to fix more cves related to nodejs.
We also might need to support multiple version in .nvmrc.
Since we do not want to do a installation of dependency during the build, this needs to have some improvements in both categories:
Thanks.
The text was updated successfully, but these errors were encountered: