Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support release process for opensearch-testcontainers #2656

Closed
reta opened this issue Sep 23, 2022 · 18 comments
Closed

Support release process for opensearch-testcontainers #2656

reta opened this issue Sep 23, 2022 · 18 comments
Assignees

Comments

@reta
Copy link
Contributor

reta commented Sep 23, 2022

Is your feature request related to a problem? Please describe

We have a new repository https://github.com/opensearch-project/opensearch-testcontainers/ to support OpenSearch integration with TestContainers.

Describe the solution you'd like

The release process is not yet in place, the artifacts are: signed JARs under org.opensearch group (Sonatype or alternative public Apache Maven repositories).

Describe alternatives you've considered

N/A

Additional context

@peterzhuamazon please hint what should be done, happy to work on that, thank you!

@reta reta added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Sep 23, 2022
@peterzhuamazon peterzhuamazon added clients release and removed enhancement New Enhancement untriaged Issues that have not yet been triaged labels Sep 29, 2022
@peterzhuamazon
Copy link
Member

[Triage] This requires integration with Maven like other client releases such as data prepper
https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/data-prepper/release-data-prepper-all-artifacts.jenkinsfile#L121-L170

@reta let us have more talks on this on the actual release timing.

cc: @bbarani

@reta
Copy link
Contributor Author

reta commented Sep 29, 2022

thanks @peterzhuamazon, anything pending from my side or you guys are going to discuss it internally?

@dblock
Copy link
Member

dblock commented Sep 30, 2022

I think you should copy the newer opensearch-project/opensearch-java#187 and opensearch-project/opensearch-java#188 and ... that's it?

@peterzhuamazon
Copy link
Member

I think you should copy the newer opensearch-project/opensearch-java#187 and opensearch-project/opensearch-java#188 and ... that's it?

There is more than that @dblock I will sync up with reta at a latter time.
Thanks.

@dblock
Copy link
Member

dblock commented Oct 3, 2022

@peterzhuamazon I'd like to have "something that can be replicated/copied by other projects" as an outcome of this exercise.

@peterzhuamazon
Copy link
Member

Talked with @reta and he will use references from data prepper and opensearch java to create a jenkinsfile, which includes calling existing libs to publish snapshots and maven central.

Infra will setup the webhook and token for the official releases to be happened through creation of tags.

Thanks.

@peterzhuamazon
Copy link
Member

We will do the production release at another time with another Jenkins workflow.

Current snapshot workflow:

@dblock
Copy link
Member

dblock commented Oct 19, 2022

I love this. Is there a cookbook of how to do this for any repo? Should we document this in opensearch-build for the next person?

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Oct 19, 2022

I love this. Is there a cookbook of how to do this for any repo? Should we document this in opensearch-build for the next person?

We will have a meeting on this and hope we can have a blog as well to describe what is needed to onboard.

@peterzhuamazon
Copy link
Member

@reta
Copy link
Contributor Author

reta commented Oct 24, 2022

I love this. Is there a cookbook of how to do this for any repo? Should we document this in opensearch-build for the next person?

We will have a meeting on this and hope we can have a blog as well to describe what is needed to onboard.

@dblock we have just one more thing left for this week - check that releases work - and than I will document everything + port it to spring-data-opensearch

@peterzhuamazon
Copy link
Member

I love this. Is there a cookbook of how to do this for any repo? Should we document this in opensearch-build for the next person?

We will have a meeting on this and hope we can have a blog as well to describe what is needed to onboard.

@dblock we have just one more thing left for this week - check that releases work - and than I will document everything + port it to spring-data-opensearch

There is still something that we need some overhaul once all the things are released.
I will sync up to you later on the details to make it rock solid.

Thanks.

@peterzhuamazon
Copy link
Member

We have released OpenSearch Testcontainers 2.0.0 with @reta:

image

https://build.ci.opensearch.org/job/opensearch-testcontainers-release/7/

https://github.com/opensearch-project/opensearch-testcontainers/releases/tag/release-2.0.0

There are still some things to improve and I will work with @reta on that.

Thanks.

@peterzhuamazon
Copy link
Member

@peterzhuamazon
Copy link
Member

@reta please feel free to close this issue once all the related changes are addressed.

Thanks.

@reta reta closed this as completed Oct 27, 2022
@peterzhuamazon
Copy link
Member

Releasing 1.0.0 with @reta on the official maven central release.

@peterzhuamazon
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants