Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate: Update the manifest refs to tags. #2546

Closed
Tracked by #1361
prudhvigodithi opened this issue Sep 2, 2022 · 5 comments · Fixed by #4874
Closed
Tracked by #1361

Automate: Update the manifest refs to tags. #2546

prudhvigodithi opened this issue Sep 2, 2022 · 5 comments · Fixed by #4874
Assignees
Labels
enhancement New Enhancement good first issue Good for newcomers

Comments

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Sep 2, 2022

Is your feature request related to a problem? Please describe

After every release the Post release activity is to update the manifest refs to point to the generated tags, here is an example manual PR .

Describe the solution you'd like

Have an jenkins jobs or extend existing jenkins job that cuts the tag for every component, followed by to raise a PR with updated manifest, where ref value inside the manifest points to the right tag.

Describe alternatives you've considered

No response

Additional context

No response

@prudhvigodithi prudhvigodithi added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Sep 2, 2022
@dblock
Copy link
Member

dblock commented Sep 5, 2022

+1 on extending the existing job

@bbarani
Copy link
Member

bbarani commented Sep 15, 2022

[Triage] We will work on auto updating the manifest with corresponding tag information after every release.

@bbarani bbarani removed the untriaged Issues that have not yet been triaged label Sep 16, 2022
@gaiksaya gaiksaya added the good first issue Good for newcomers label Sep 13, 2023
@hitenshKharva
Copy link
Contributor

I would like to try fixing this issue.

@hitenshKharva
Copy link
Contributor

@gaiksaya @peterzhuamazon I went through the approaches discussed during the office hours but I am still confused on the approach to fix this issue.
Few questions:

  1. when a new release tag is generated, where should I fetch it?
  2. My best case approach if we can run a python script via github action to replace manifest refs to tags? Does that sound good?
  3. Also, if we go ahead with above approach what will be the optimal way to trigger the Github action once new tags are generated?

Thanks.

@gaiksaya
Copy link
Member

Hey!

  1. Release tags are generated after each release of OpenSearch. This is the workflow responsible for creating tags across all the repositories. Source coded here. This is the underlying library which is run in the above workflow.
  2. There are 3 options:
    i. Create a new groovy library that will update the refs and create a pull request (all in one)
    ii. Create a python script that can be run on anything (jenkins/GHA)and then create pull request: Example
    iii. Create a simple GHA workflow that takes version as an input and does the update using it.
  3. If using GitHub actions, it will be triggered using workflow_dispatch event that will take version as an input. Example: https://github.com/opensearch-project/data-prepper/blob/main/.github/workflows/release.yml#L3-L14. We can send dispatch as a post condition to above release-tag workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement good first issue Good for newcomers
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants