-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Improve tag creation pipeline to skip repositories without write permission for the bot account #1860
Comments
I think it's a bad idea. Permissions should be fixed anyway, and the workflow can be rerun as many times as needed as it skips correct existing tags. If you stop failing it, we'll never know that permissions are missing. |
@dblock We are not going to stop failing rather we dont want the process to terminate in the middle of the tagging process when it doesn't have access to any specific repo. The job will still fail listing the repos that has issue but it will create tags on other repos not affected by access issues. |
If the pipeline failed, we should always rerun the workflow to make sure tags are successfully created on other components until the job passes. |
[triage] We would want to create tags for all repositories, if creation fails, the repository should be skipped and continue for the remaining repositories. The job should then fail listing down the failed repositories. |
Closing this issue as this enhancement have been implemented with PR linked above. |
As of now, the release tag creation will fail the build if the bot account does not have permission to write in any repository.
This requires our team member with access to manually create a tag on those repos.
We should let the pipeline skip these repos, and output a list of repos that requires to add the bot with write access, and we can manually create the tags after the release pipeline run.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: