Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTS] Do not log status code in test result if PASS #1767

Closed
kavilla opened this issue Mar 17, 2022 · 1 comment · Fixed by #3021
Closed

[TESTS] Do not log status code in test result if PASS #1767

kavilla opened this issue Mar 17, 2022 · 1 comment · Fixed by #3021
Labels
bug Something isn't working enhancement New Enhancement

Comments

@kavilla
Copy link
Member

kavilla commented Mar 17, 2022

Is your feature request related to a problem? Please describe

I'm might the only but with this to string format logs output like the following:

2022-03-15 22:03:36 INFO     | alerting             | with-security        | PASS  |    0 |

If all the tests passes. With purely looking at log messages I would assume that this means 0 tests passed. But internally I know that that 0 is actually the status code of 0 which means success. However, I also know that for OpenSearch Dashboards cypress tests, the exit code is equal to the amount of tests failed if the test runner was able to run the tests.

Describe the solution you'd like

Don't output the status code on PASS

For example:

2022-03-15 22:03:36 INFO     | alerting             | with-security        | PASS  |

Describe alternatives you've considered

No response

Additional context

No response

@kavilla kavilla added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Mar 17, 2022
@zelinh zelinh removed the untriaged Issues that have not yet been triaged label Mar 22, 2022
@zelinh
Copy link
Member

zelinh commented Mar 22, 2022

[Triage] We know what to do then moving this to our product backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants