Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.0 distribution builds failing due to Shadow plugin gradle version bump #1587

Closed
ohltyler opened this issue Feb 3, 2022 · 4 comments
Closed

Comments

@ohltyler
Copy link
Member

ohltyler commented Feb 3, 2022

Common utils is not upgraded to Gradle 7, which is causing this failure when trying to build the common-utils component for 1.3.0:

FAILURE: Build failed with an exception.
 
* Where:
Build file '/tmp/tmp5rc4dbsg/common-utils/build.gradle' line: 67
 
* What went wrong:
A problem occurred evaluating root project 'common-utils'.
> Failed to apply plugin [class 'com.github.jengelman.gradle.plugins.shadow.ShadowBasePlugin']
  ​> This version of Shadow supports Gradle 7.0+ only. Please upgrade.

This failure occurred after the Shadow plugin bumped to Gradle 7.0+ as part of this PR: opensearch-project/OpenSearch#2033

Tracking issue in common-utils: opensearch-project/common-utils#101

@saratvemulapalli
Copy link
Member

Thanks @ohltyler for reporting this.
This is due to OpenSearch moving to a new version of Shadow plugin due to Log4J CVE.
Ref: opensearch-project/OpenSearch#2033

I see couple of options:

  1. If the plugin/library wants to use something exported by OpenSearch, they can continue to do so via upgrading gradle.
  2. If not, they can explicitly add a dependency for the older version of a shadow plugin. This includes fixing common-utils, job-scheduler, alerting and notifications. Ref: Search link
  3. Revert the change on 1.x line of OpenSearch

@ohltyler @dblock @reta what do you guys think?

@reta
Copy link
Contributor

reta commented Feb 3, 2022

@saratvemulapalli I think we have to revert the change for 1.x (sadly), we cannot break existing plugins. The same discussion we have had with @dblock when we were updating to Gradle 7.x: it was a breaking change for 1.x so the strong point was made to keep the promise and never make breaking changes within minor / patch releases (as such, 1.x is still on Gradle 6.x). Thank you.

@ohltyler ohltyler changed the title 1.3.0 distribution builds failing due to common-utils Gradle version 1.3.0 distribution builds failing due to Shadow plugin gradle version bump Feb 3, 2022
@saratvemulapalli
Copy link
Member

Thanks @reta ! I agree.
I did put up a PR to revert the change in 1.x.
opensearch-project/OpenSearch#2047

@saratvemulapalli
Copy link
Member

The change is merged.
Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants