Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make using Docker images in CI reliable and repeatable #1207

Closed
9 tasks
dblock opened this issue Dec 1, 2021 · 3 comments
Closed
9 tasks

Make using Docker images in CI reliable and repeatable #1207

dblock opened this issue Dec 1, 2021 · 3 comments
Labels
enhancement New Enhancement good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source.

Comments

@dblock
Copy link
Member

dblock commented Dec 1, 2021

Is your feature request related to a problem? Please describe

Currently images used in https://github.com/opensearch-project/opensearch-build/tree/main/docker/ci/dockerfiles contain too many things and keep changing while development is ongoing. Old images get deleted, too. This makes CI non-repeatable and non-reliable.

Describe the solution you'd like

Propose to follow the GitHub actions' images' model in every way.

  • Immutable images, so that one can check out source from this repo at any time and reproduce builds without any changes.
  • Reduce images to not contain the kitchen sink of dependencies. Make it easier to install a custom version of java/ruby/whatever at build time so developers can move fast.
  • Add ability to target the "latest" image available for ongoing CI where a specific image version doesn't matter.
  • Add CI image locking to the manifest .lock mechanism from latest -> specific current image.
  • Enable developers to contribute, aka commit changes to images, build and push them.
  • Make a menu of images available for a developer to pick from for various platforms.
  • Document images and working with images.
  • Add CI to verify that the manifests contain images that are valid.
  • Centralized constants file for docker Images in Jenkinsfile #1325

Describe alternatives you've considered

No response

Additional context

No response

@dblock dblock added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Dec 1, 2021
@dblock dblock changed the title Make using images in CI reliable and repeatable Make using Docker images in CI reliable and repeatable Dec 1, 2021
@zelinh zelinh removed the untriaged Issues that have not yet been triaged label Dec 9, 2021
@zelinh
Copy link
Member

zelinh commented Dec 9, 2021

[Triage] Added to Product backlog and we will start look into it.

@zelinh zelinh added the good first issue Good for newcomers label Dec 9, 2021
@bbarani bbarani added the hacktoberfest Global event that encourages people to contribute to open-source. label Oct 5, 2022
@gaiksaya
Copy link
Member

We have added most of what is requested in the solution. We are lacking documentation of available CI images.
cc: @peterzhuamazon

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Aug 23, 2024

Sure.

Close this as we have already used docker for majority of the builds, except macos. The documentations has been tracked in another issue.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source.
Projects
None yet
Development

No branches or pull requests

5 participants