Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSB 2.0.0] Reassess renamed-component changes #592

Open
2 tasks
IanHoang opened this issue Jul 23, 2024 · 5 comments
Open
2 tasks

[OSB 2.0.0] Reassess renamed-component changes #592

IanHoang opened this issue Jul 23, 2024 · 5 comments
Assignees
Labels

Comments

@IanHoang
Copy link
Collaborator

IanHoang commented Jul 23, 2024

Describe the bug

It's been a while since we've checked the renamed components. @beaioun, @cgchinmay, and I will be gathering changes from the renaming-components and rename-provision branch and place them on top of most recent mainline changes.

We'll then test the current changes to ensure they work before proceeding to add other renamed component changes.

To reproduce

  • Add previous changes on top of recent mainline changes
  • Test current changes
@IanHoang IanHoang added bug Something isn't working untriaged 2.0.0 and removed bug Something isn't working untriaged labels Jul 23, 2024
@IanHoang IanHoang self-assigned this Jul 23, 2024
@beaioun
Copy link
Collaborator

beaioun commented Jul 25, 2024

@IanHoang I will start working on testing over the weekends

@IanHoang
Copy link
Collaborator Author

Testing Changes in Renamed Components Branch

If cluster-configs and opensearch-plugins are not listable, update the benchmark.ini to use the following

[cluster_configs]
default.dir = default-cluster-config

@IanHoang
Copy link
Collaborator Author

Reproduce Renamed Components Branch Setup

  1. Git clone the repository https://github.com/IanHoang/opensearch-benchmark/tree/renamed-components
  2. Run make install
  3. Run source .venv/bin/activate
  4. Run python3 -m pip install -e .

@cgchinmay
Copy link
Collaborator

cgchinmay commented Aug 2, 2024

Hi @IanHoang I am not seeing any issues. Here are the steps I tried. did not make any changes to bechmark.ini. Let me know if I am missing something

1. git clone https://github.com/opensearch-project/opensearch-benchmark.git

2. git checkout -b local-renaming-components origin/renaming-components

3. make prereq

4. make install

5. source .venv/bin/activate

6. python3 -m pip install -e .

7. opensearch-benchmark list cluster-configs 

Available cluster-configs:

Name                  Type            Description
--------------------  --------------  --------------------------------------
16gheap               cluster-config  Sets the Java heap to 16GB
1gheap                cluster-config  Sets the Java heap to 1GB
24gheap               cluster-config  Sets the Java heap to 24GB
2gheap                cluster-config  Sets the Java heap to 2GB
4gheap                cluster-config  Sets the Java heap to 4GB
8gheap                cluster-config  Sets the Java heap to 8GB
defaults              cluster-config  Sets the Java heap to 1GB
basic-license         mixin           Basic License
debug-non-safepoints  mixin           More accurate CPU profiles
ea                    mixin           Enables Java assertions
fp                    mixin           Preserves frame pointers
g1gc                  mixin           Enables the G1 garbage collector
parallelgc            mixin           Enables the Parallel garbage collector
trial-license         mixin           Trial License
unpooled              mixin           Enables Netty's unpooled allocator


8. cat osbenchmark/resources/benchmark.ini

[meta]
config.version = 17

[system]
env.name = local

[node]
root.dir = ${CONFIG_DIR}/benchmarks
src.root.dir = ${CONFIG_DIR}/benchmarks/src

[source]
remote.repo.url = https://github.com/opensearch-project/OpenSearch.git
opensearch.src.subdir = opensearch

[benchmarks]
local.dataset.cache = ${CONFIG_DIR}/benchmarks/data

[results_publishing]
datastore.type = in-memory
datastore.host =
datastore.port =
datastore.secure = False
datastore.user =
datastore.password =


[workloads]
default.url = https://github.com/opensearch-project/opensearch-benchmark-workloads

[provision_configs]
default.dir = default-provision-config

[defaults]
preserve_benchmark_candidate = false

[distributions]
release.cache = true

@IanHoang IanHoang pinned this issue Aug 5, 2024
@IanHoang IanHoang moved this from Todo to In Progress in Performance Roadmap Aug 13, 2024
@IanHoang IanHoang removed the status in Performance Roadmap Aug 13, 2024
@IanHoang IanHoang moved this to In Progress in Performance Roadmap Aug 13, 2024
@gkamat gkamat moved this from Miscellaneous to 🏗 In progress in OpenSearch Benchmark Roadmap Sep 13, 2024
@IanHoang
Copy link
Collaborator Author

Will need to commit to a release date for this. Will work closely with maintainers to finalize on this.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Performance Roadmap Sep 25, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Engineering Effectiveness Board Sep 25, 2024
@IanHoang IanHoang reopened this Sep 25, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in Engineering Effectiveness Board Sep 25, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Performance Roadmap Sep 25, 2024
@IanHoang IanHoang moved this from 🏗 In progress to Next Quarter in OpenSearch Benchmark Roadmap Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏗 In progress
Status: Next Quarter
Status: In Progress
Development

No branches or pull requests

3 participants