Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] : Implementation of two way communication between PPL query and UI changes #798

Closed
abasatwar opened this issue Jun 10, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@abasatwar
Copy link
Contributor

Implementation of two way communication between PPL query and UI changes (features v1) according to #787

requirements -
On change of PPL query, UI of dimensions and metrics need to be updated and vice a versa.

@rinku-kumar-psl
Copy link
Contributor

Hi @mengweieric @btzeng @anirudha

We explored dimension and metrics implementation with the reference of superset charts and issue opensearch-project/dashboards-observability#125.
As per our Understanding:

  • There should be interval selector UI for dimensions like (year, month, days, ....)
  • Along with the fields selector there should be input fields to take interval as a number in dimension
  • No need for aggregation methods in dimension if it's a time-series chart
  • for metrics, there should be one label and custom_label fields to achieve customized ppl query

Please provide us with more insights for Query Manager and Query manager API.

@abasatwar
Copy link
Contributor Author

This is implemented by Eric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants