Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No support for http urls in notification channels #232

Closed
Tracked by #231
lezzago opened this issue Jul 19, 2021 · 2 comments
Closed
Tracked by #231

[BUG] No support for http urls in notification channels #232

lezzago opened this issue Jul 19, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@lezzago
Copy link
Member

lezzago commented Jul 19, 2021

Describe the bug
The notification plugin does not support "http" urls for the notification channels like Webhook. The alerting plugin already supports this and breaks functionality when integrating with notification plugin.

To Reproduce
N/A

Expected behavior
The notification plugin should support "http" urls.

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@lezzago lezzago added Beta bug Something isn't working untriaged labels Jul 19, 2021
@zhongnansu
Copy link
Member

I thought the original idea is to not support http, only support https. As code here suggests

@lezzago
Copy link
Member Author

lezzago commented Jul 22, 2021

Currently Alerting plugin supports http, so this can break integration for some users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants