Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Reranking makes relevancy worse, somehow #588

Closed
HenryL27 opened this issue Feb 5, 2024 · 4 comments
Closed

[BUG] Reranking makes relevancy worse, somehow #588

HenryL27 opened this issue Feb 5, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@HenryL27
Copy link
Contributor

HenryL27 commented Feb 5, 2024

What is the bug?

Doing some testing on a cluster, and relevancy seems to decrease...
Anecdotally, the reranking feature has made search quality better, but I've only ever run it on single node clusters. Now, relevency gets worse, e.g. (ndcg@10)

dataset pure neural minilm reranker bge reranker quantized bge reranker
fiqa 0.3859 0.3098 0.2574 0.0783

How can one reproduce the bug?

cluster with 3 r5.8xlarge

What is the expected behavior?

ndcg@10 should get better

What is your host/environment?

Operating system, version.

Do you have any screenshots?

If applicable, add screenshots to help explain your problem.

Do you have any additional context?

Add any other context about the problem.

@HenryL27 HenryL27 added bug Something isn't working untriaged labels Feb 5, 2024
@navneet1v
Copy link
Collaborator

@HenryL27 when you run the same dataset with single node is the relevancy better?

@HenryL27
Copy link
Contributor Author

HenryL27 commented Feb 5, 2024

Not sure. deploying the model on only one node doesn't do it tho

@navneet1v
Copy link
Collaborator

@HenryL27 is the bug resolved?

@HenryL27
Copy link
Contributor Author

HenryL27 commented Feb 6, 2024

ran on a single node cluster and I have similar results, so I think it's just a model problem. I think we can close this.

@HenryL27 HenryL27 closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants