Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #727

Closed
Tracked by #125
dblock opened this issue Feb 14, 2023 · 5 comments
Closed
Tracked by #125

Comments

@dblock
Copy link
Member

dblock commented Feb 14, 2023

Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.

@ylwu-amzn
Copy link
Collaborator

@dblock Do we have any doc explaining the definition of maintainers and codeowners, and their difference?

@dblock
Copy link
Member Author

dblock commented Mar 30, 2023

CODEOWNERS = https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
MAINTAINERS = people with "Maintain" level permissions

Feel free to contribute links to .github, I think we didn't spell that out.

@dblock
Copy link
Member Author

dblock commented Mar 30, 2023

Permissions don't match maintainers/codeowners. For example the entire plugins group has admin rights. Please work with an admin to fix.

Screenshot 2023-03-30 at 10 32 25 AM

@dblock dblock reopened this Mar 30, 2023
@ylwu-amzn
Copy link
Collaborator

Thanks @dblock , we don't have permission to edit that. @bbarani helped remove extra teams/guys and add the correct maintainers, Thanks @bbarani.

I will close this issue now. Feel free to reopen if you see more issues.

@dblock
Copy link
Member Author

dblock commented Apr 4, 2023

Verified actual permissions, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants