[Backport Main] Add UnmodifiableOnRestore property to index.knn setting #2476
+144
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntians
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
0ctopus13prime
as code owners
anntians
force-pushed
the
backport/backport-2445-to-main
branch
from
8d5e0d3 to
1e26db8
Compare
|
@anntians Can you please rebase your code? |
|
@anntians Can you rebase? |
…roject#2445) * Add UnmodifiableOnRestore property to index.knn setting Signed-off-by: AnnTian Shao <[email protected]> * Update tests with helper methods Signed-off-by: AnnTian Shao <[email protected]> * Update test names Signed-off-by: AnnTian Shao <[email protected]> * Add to changeLog and fixes to tests Signed-off-by: AnnTian Shao <[email protected]> --------- Signed-off-by: AnnTian Shao <[email protected]> Co-authored-by: AnnTian Shao <[email protected]> (cherry picked from commit 1d2c4c0)
anntians
force-pushed
the
backport/backport-2445-to-main
branch
from
1e26db8 to
dd403a1
Compare
CHANGELOG.md
Outdated
| @@ -22,6 +22,18 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| ### Features | |||
| ### Enhancements | |||
| ### Bug Fixes | |||
| * Fixing the bug when a segment has no vector field present for disk based vector search (#2282)[https://github.com/opensearch-project/k-NN/pull/2282] | |||
There was a problem hiding this comment.
Can you fix the changelog ?
anntians
force-pushed
the
backport/backport-2445-to-main
branch
2 times, most recently
from
2b8bcc8 to
f4b8d37
Compare
Signed-off-by: AnnTian Shao <[email protected]>
anntians
force-pushed
the
backport/backport-2445-to-main
branch
from
f4b8d37 to
ac33c13
Compare
naveentatikonda
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on another PR opensearch-project/OpenSearch#16957. In the other PR we added a new Setting property UnmodifiableOnRestore to prevent settings from being modified on restore. So in this PR we're adding that new UnmodifiableOnRestore property to the index.knn setting to prevent it from being modified or removed on restore snapshot.
Related Issues
Resolves #2334
Also resolves Issue 17019 in Core Opensearch repository opensearch-project/OpenSearch#17019
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.