Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warmup API does not work for files created with older version of libs #308

Closed
jmazanec15 opened this issue Mar 7, 2022 · 0 comments
Closed
Labels
bug Something isn't working v1.3.0 Issues and PRs related to version 1.3.0 v2.0.0

Comments

@jmazanec15
Copy link
Member

Description

The warmup API decides what segments to load based on the file name it would build for the segments: https://github.com/opensearch-project/k-NN/blob/main/src/main/java/org/opensearch/knn/index/KNNIndexShard.java#L129-L130. The problem with this is that for segment files built with older versions of a library, the lib version is included in the file name. This leads to these files getting skipped during warmup

Proposed solution

Update warmup API logic to get files in a backwards compatible manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.3.0 Issues and PRs related to version 1.3.0 v2.0.0
Projects
None yet
Development

No branches or pull requests

1 participant