Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readiness of Faiss Library Version Bump #1409

Closed
heemin32 opened this issue Jan 24, 2024 · 1 comment
Closed

Readiness of Faiss Library Version Bump #1409

heemin32 opened this issue Jan 24, 2024 · 1 comment
Assignees

Comments

@heemin32
Copy link
Collaborator

K-NN added custom patch on faiss library to support multi-vector. 709b448

Recently faiss library made a change in the HNSW.cpp code which conflict with implementation in K-NN. https://github.com/facebookresearch/faiss/pull/3190/files#diff-5335385bb9a771bae868c8c908725eda0a9de22f7c0781dd27488f3ed3e50b60

Because of the conflict, we cannot bump the faiss version. We need to make a change so that there is no conflict with the latest code in faiss library.

@jmazanec15
Copy link
Member

Closing in favor of #1508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants