From b0092c0f01a28555046ff04bac2d2b8b88096555 Mon Sep 17 00:00:00 2001 From: John Mazanec Date: Thu, 7 Apr 2022 12:59:38 -0700 Subject: [PATCH] Update docs and fix property bug Signed-off-by: John Mazanec --- DEVELOPER_GUIDE.md | 9 ++++----- gradle.properties | 2 +- qa/bwc/build.gradle | 1 + 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/DEVELOPER_GUIDE.md b/DEVELOPER_GUIDE.md index 18213fa9de..5769f25188 100644 --- a/DEVELOPER_GUIDE.md +++ b/DEVELOPER_GUIDE.md @@ -251,14 +251,13 @@ The purpose of Backwards Compatibility Testing and different types of BWC tests Use these commands to run BWC tests for k-NN: -1. Mixed cluster test: `./gradlew knnBwcCluster#mixedClusterTask -Dtests.security.manager=false` -2. Rolling upgrade tests: `./gradlew knnBwcCluster#rollingUpgradeClusterTask -Dtests.security.manager=false` -3. Full restart upgrade tests: `./gradlew knnBwcCluster#fullRestartClusterTask -Dtests.security.manager=false` -4. `./gradlew bwcTestSuite -Dtests.security.manager=false` is used to run all the above bwc tests together. +1. Rolling upgrade tests: `./gradlew :qa:bwc:rollingUpgradeClusterTest` +2. Full restart upgrade tests: `./gradlew :qa:bwc:fullRestartClusterTest` +3. `./gradlew :qa:bwc:bwcTestSuite` is used to run all the above bwc tests together. Use this command to run BWC tests for a given Backwards Compatibility Version: ``` -./gradlew bwcTestSuite -Dbwc.version=1.0.0.0-SNAPSHOT +./gradlew :qa:bwc:bwcTestSuite -Dbwc.version=1.0.0 ``` Here, we are testing BWC Tests with BWC version of plugin as 1.0.0.0. Make sure to add the binary file of that version in the bwc directory in resources. diff --git a/gradle.properties b/gradle.properties index 66d37b5a13..94c6ea9346 100644 --- a/gradle.properties +++ b/gradle.properties @@ -4,7 +4,7 @@ # version=1.0.0 -knn_bwc_version=1.3.1 +systemProp.bwc.version=1.3.1 org.gradle.jvmargs=--add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \ --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \ diff --git a/qa/bwc/build.gradle b/qa/bwc/build.gradle index f839b937ab..1986812e84 100644 --- a/qa/bwc/build.gradle +++ b/qa/bwc/build.gradle @@ -24,6 +24,7 @@ dependencies { def tmp_dir = project.file('build/private/artifact_tmp').absoluteFile tmp_dir.mkdirs() +String knn_bwc_version = System.getProperty("bwc.version") // Task to pull k-NN plugin from archive task pullBwcPlugin {