Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default CI Java Version to Java 11, run tests on 8, 14 and 17 #200

Closed
3 tasks done
Tracked by #64
dblock opened this issue Nov 17, 2021 · 3 comments
Closed
3 tasks done
Tracked by #64

Default CI Java Version to Java 11, run tests on 8, 14 and 17 #200

dblock opened this issue Nov 17, 2021 · 3 comments
Labels

Comments

@dblock
Copy link
Member

dblock commented Nov 17, 2021

Coming from opensearch-project/opensearch-plugins#64, default CI Java version to 11 (LTS), and run tests on 8, 14 and 17.

  • Change the default Java version for CI in GitHub actions from 14/15 to 11 (LTS).
  • Add Java 8, 14 (used before), and 17 (next LTS) to the CI matrix.
  • Document Java versions in DEVELOPER_GUIDE.md.
@dblock
Copy link
Member Author

dblock commented Mar 9, 2022

@downsrob I believe you only have JDK8 left to do for 1.3.0 here.

@downsrob
Copy link
Contributor

downsrob commented Mar 9, 2022

Just built with JDK8 and got a compilation failure

e: /home/runner/work/index-management/index-management/src/main/kotlin/org/opensearch/indexmanagement/indexstatemanagement/step/forcemerge/WaitForForceMergeStep.kt: (62, 56): Type mismatch: inferred type is Long but BigDecimal! was expected

@dblock Do we need build support for JDK 8 in the 1.3 release? As in we will need to get this fixed on the 1.3 branch by the end of the day?

@downsrob
Copy link
Contributor

There were a couple of small lines to change to get JDK 8 building. Not sure if this is something I should backport after the code freeze date, so I just have it in a draft PR here #297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants