Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for build version qualifiers. #166

Closed
Tracked by #1632
dblock opened this issue Mar 11, 2022 · 2 comments
Closed
Tracked by #1632

Add support for build version qualifiers. #166

dblock opened this issue Mar 11, 2022 · 2 comments
Assignees
Labels

Comments

@dblock
Copy link
Member

dblock commented Mar 11, 2022

Coming from opensearch-project/opensearch-build#1632, add support for -Dbuild.version_qualifier=.

The distribution build process now supports passing additional optional qualifiers other than the 3 digit versions, e.g. 2.0.0-alpha1. Add the ability to pass additional qualifier to build scripts, and generate artifacts with a version that includes the qualifier.

@peterzhuamazon
Copy link
Member

@kavilla
Copy link
Member

kavilla commented Apr 1, 2022

Hello @downsrob, I see you are assigned tot his issue.

Unfortunately for OpenSearch Dashboards we don't have a nice build param as OpenSearch side has yet. You will be able to build and connect successfully to OpenSearch Dashboards yarn plugin_helpers build --opensearch-dashboards-version=2.0.0-rc1) with an OSD plugin 2.0.0.0 but this will fail within the distribution build.

As for 2.0.0-rc1 we ask plugins to bump their version [here] to be 2.0.0.0-rc1 to be supported within the build distribution.

My opinion, is to leave opensearchDashboardsVersion untouched. You can then utilize OpenSearch Dashboards main. Within the build repo we build OpenSearch Dashboards and plugins with a qualifier. This will set OpenSearch Dashboards to be 2.0.0-rc1 and within plugins "opensearchDashboardsVersion": "2.0.0-rc1". So it will be compatible and succeed in the building of distributions.

Let me know if you have any follow up questions.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants