Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][opensearch] dead "minimum_master_nodes" setting still listed #167

Open
rursprung opened this issue Dec 10, 2021 · 4 comments
Open
Labels
bug Something isn't working

Comments

@rursprung
Copy link

Describe the bug
the opensearch chart still contains the commented-out discovery.zen.minimum_master_nodes:

# # minimum_master_nodes need to be explicitly set when bound on a public IP
# # set to 1 to allow single node clusters
# discovery.zen.minimum_master_nodes: 1

however, since Elasticsearch 7.0 this setting has been ignored: release notes for 7.0 (see also elastic/elasticsearch#37868)

accordingly this should probably be removed (unclear: should something else be added instead as a recommendation?)

To Reproduce
check the default config provided in the helm charts.

Expected behavior
only settings are listed which are still supported and which have an effect.

Chart Name
opensearch

Screenshots
n/a

Host/Environment (please complete the following information):
n/a

Additional context
i saw that this has also been touched upon in #54

@rursprung rursprung added bug Something isn't working untriaged Issues that have not yet been triaged labels Dec 10, 2021
@TheAlgo TheAlgo removed the untriaged Issues that have not yet been triaged label Dec 10, 2021
@TheAlgo
Copy link
Member

TheAlgo commented Dec 10, 2021

Yes this needs to be removed from the values.yaml as per my knowledge to avoid any confusion. I will raise a fix for this to remove it if @rursprung is not planning any PR

@rursprung
Copy link
Author

i'm not planning to contribute a PR here because i'm not familiar enough with what the proper settings would be for this use-case.
i'm actually hoping to see what you'll be doing :D

@peterzhuamazon
Copy link
Member

@TheAlgo any progress?
Thanks.

@peterzhuamazon
Copy link
Member

@TheAlgo Any updates?
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📦 Backlog
Development

No branches or pull requests

3 participants