-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][opensearch] dead "minimum_master_nodes" setting still listed #167
Comments
Yes this needs to be removed from the |
i'm not planning to contribute a PR here because i'm not familiar enough with what the proper settings would be for this use-case. |
@TheAlgo any progress? |
@TheAlgo Any updates? |
Describe the bug
the opensearch chart still contains the commented-out
discovery.zen.minimum_master_nodes
:helm-charts/charts/opensearch/values.yaml
Lines 50 to 52 in 12e6af6
however, since Elasticsearch 7.0 this setting has been ignored: release notes for 7.0 (see also elastic/elasticsearch#37868)
accordingly this should probably be removed (unclear: should something else be added instead as a recommendation?)
To Reproduce
check the default config provided in the helm charts.
Expected behavior
only settings are listed which are still supported and which have an effect.
Chart Name
opensearch
Screenshots
n/a
Host/Environment (please complete the following information):
n/a
Additional context
i saw that this has also been touched upon in #54
The text was updated successfully, but these errors were encountered: