[BUG] OpenSearch chart fails when RBAC is enabled.

[mprimeaux]

Describe the bug
A defect was introduced in release 1.2.0 involving role.yaml with this commit.

When setting rbac.create: true, the following error occurs:

Error: INSTALLATION FAILED: YAML parse error on opensearch/templates/role.yaml: error converting YAML to JSON: yaml: line 4: did not find expected key
make: *** [install] Error 1

I haven't debugged it yet but suspect it has to do with how opensearch.labels is being computed in _helpers.tpl or indented here or both.

To Reproduce
Steps to reproduce the behavior:

1. Enable RBAC as per above.
2. Run helm install opensearch opensearch/opensearch
3. See error

Expected behavior
I expect the chart to be deployed as it does with version 1.1.0.

Chart Name
OpenSearch

Screenshots
N/A (Not Applicable)

Host/Environment (please complete the following information):

• Helm Version: 3.7.1
• Kubernetes Version: 1.21

I'll work to debug and issue a PR. For now, we've reverted to the OpenSearch Helm chart 1.1.0.

[peterzhuamazon]

@smlx mind taking a look on this? Thanks.

[mprimeaux]

I have narrowed it down to line 7 in role.yaml. I should have a PR today.

[mprimeaux]

The metadata stanza was missing the labels:.

metadata:
  name: {{ $fullName | quote }}
+  labels:
  {{- include "opensearch.labels" . | nindent 4 }}

I'm also adding a CI test for it so we don't have to worry about it again.

[mprimeaux]

CI tests passed. I'll issue a PR next.

[mprimeaux]

Thanks @peterzhuamazon. Appreciate your and the maintainer's support.