-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document new Split and Sort SearchResponseProcessors #7767
Document new Split and Sort SearchResponseProcessors #7767
Conversation
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
@kolchfa-aws Ready for doc review! |
Signed-off-by: Fanit Kolchina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @dbwiddis! I edited in place. Moving to editorial review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbwiddis @kolchfa-aws Please see my changes and let me know if you have any questions. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]>
Accepted all the recommendations! |
Note I'm still waiting for the PRs to get merged (hopefully by today) :) |
No problem. If they are not merged, we can revert this PR 😄 |
Well one is now merged, other should be shortly, so we should be gtg! |
And, the other one is merged. 🎉 |
…ect#7767) * Add documentation for Sort SearchRequestProcessor Signed-off-by: Daniel Widdis <[email protected]> * Add documentation for Split SearchRequestProcessor Signed-off-by: Daniel Widdis <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Update _ingest-pipelines/processors/split.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> * Update _search-plugins/search-pipelines/sort-processor.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> * Update _search-plugins/search-pipelines/split-processor.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> * Update _search-plugins/search-pipelines/split-processor.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> * Update _search-plugins/search-pipelines/split-processor.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> * Update _search-plugins/search-pipelines/split-processor.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: [email protected] <[email protected]>
…ect#7767) * Add documentation for Sort SearchRequestProcessor Signed-off-by: Daniel Widdis <[email protected]> * Add documentation for Split SearchRequestProcessor Signed-off-by: Daniel Widdis <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Update _ingest-pipelines/processors/split.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> * Update _search-plugins/search-pipelines/sort-processor.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> * Update _search-plugins/search-pipelines/split-processor.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> * Update _search-plugins/search-pipelines/split-processor.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> * Update _search-plugins/search-pipelines/split-processor.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> * Update _search-plugins/search-pipelines/split-processor.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Sander van de Geijn <[email protected]>
@dbwiddis thanks for contributing the sort processor. I saw the functionality is very similar to the sort ingest processor. But there is a difference between ingest and response: in the search response, there are multiple documents. Can we achieve sorting the documents in the response based on the value in for example: a sample search response:
can we sort by the
|
@mingshl that's not the spec I was asked to write to, it seems you'd want a "sort hits by field" functionality. But aren't hits supposed to be sorted by score? If you need a different functionality, please open a new issue to discuss it. Unfortunately we're within 24 hours of code freeze so there's no way it will get into 2.17.0. |
We will need a new RFC to track the rank processor to sort the search hits based on the field in the hit. |
Raised new RFC opensearch-project/OpenSearch#15631 |
Description
Documents the new Sort and Split SearchResponseProcessors.
Fixes an incorrect field name in the Ingest Split Processor docs.
Issues Resolved
Fixes #7743
Fixes #7744
Fixes #7754
Feature PRs:
Version
2.16.0
Frontend features
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.