Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add efficient filtering capability for Lucene knn #923

Closed
1 of 4 tasks
martin-gaievski opened this issue Aug 18, 2022 · 6 comments · Fixed by #1814
Closed
1 of 4 tasks

[DOC] Add efficient filtering capability for Lucene knn #923

martin-gaievski opened this issue Aug 18, 2022 · 6 comments · Fixed by #1814
Assignees
Labels
v2.4.0 'Issues and PRs related to version v2.4.0'

Comments

@martin-gaievski
Copy link
Member

martin-gaievski commented Aug 18, 2022

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.

k-NN plugin in OpenSearch will support filtering. This will allow users to define custom filters as part of the search request for knn_vector data type. Filtering functionality will be supported for case when Lucene has been defined as an engine for hnsw method.

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

opensearch-project/k-NN#376

https://github.com/martin-gaievski/k-NN/tree/poc/pre-filtering-for-lucene-engine

@Naarcha-AWS Naarcha-AWS added v2.4.0 'Issues and PRs related to version v2.4.0' 1 - Backlog Issue: The issue is unassigned or assigned but not started and removed untriaged labels Aug 22, 2022
@Naarcha-AWS Naarcha-AWS added this to the v2.4 milestone Aug 22, 2022
@alicejw1
Copy link
Contributor

10/24 Status: started research, gathered all resource specs and recording of demo. Started writing 10/24.

@hdhalter hdhalter added 2 - In progress Issue/PR: The issue or PR is in progress. and removed 1 - Backlog Issue: The issue is unassigned or assigned but not started labels Oct 26, 2022
@alicejw1
Copy link
Contributor

Update: writing content, on-target for tech review of two drafts by 11/3 this week.

@dtaivpp
Copy link
Contributor

dtaivpp commented Nov 4, 2022

@alicejw-aws and @martin-gaievski can we remove these quip links and either past the content in a comment or post it somewhere public? Thanks!

@alicejw1
Copy link
Contributor

alicejw1 commented Nov 4, 2022

hi @dtaivpp, will do! I've saved the resources for doc purposes, and removed the quip links to this issue. Not sure if they are made public or not. Thanks

@alicejw1
Copy link
Contributor

alicejw1 commented Nov 7, 2022

11-7 update: doc is in eng review with Martin and his team.
New section is in-prog to be added for outlining the top 3 use cases, and add an algorithm diagram image with a table of three types of filters that vary from very selective (2%) to medium (40%) to very selective (80%).

@alicejw1 alicejw1 added 4 - Doc review PR: Doc review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Nov 8, 2022
@alicejw1
Copy link
Contributor

alicejw1 commented Nov 8, 2022

Update: Tech review is completed 11-8, now in doc review.

@alicejw1 alicejw1 linked a pull request Nov 8, 2022 that will close this issue
@alicejw1 alicejw1 removed the 4 - Doc review PR: Doc review in progress label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants