Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document JDK version #75

Closed
dblock opened this issue Jul 8, 2021 · 3 comments
Closed

Document JDK version #75

dblock opened this issue Jul 8, 2021 · 3 comments
Labels
v1.0.0 xx-documentation Improvements or additions to documentation

Comments

@dblock
Copy link
Member

dblock commented Jul 8, 2021

OpenSearch requires JDK 11 to build at a minimum per dev guide. It has been building with JDK14 (and will be building with 11 post 1.0 with this change). The combined artifact is packaging JDK 15.0.1.

  • document the above
  • potentially document what JDK(s) we testing with, core and plugins
@dblock dblock added xx-documentation Improvements or additions to documentation v1.0.0 labels Jul 8, 2021
@aetter
Copy link
Contributor

aetter commented Jul 8, 2021

Hey @dblock, are you sure about that? My understanding is that we require 11 to build at a minimum, but that you can run OpenSearch it with 8 or 11. In general, the build instructions for a particular repo go in the README, and the documentation is more concerned with using and extending the off-the-shelf artifacts. See this PR: #62

@dblock
Copy link
Member Author

dblock commented Jul 8, 2021

Hey @dblock, are you sure about that? My understanding is that we require 11 to build at a minimum, but that you can run OpenSearch it with 8 or 11. In general, the build instructions for a particular repo go in the README, and the documentation is more concerned with using and extending the off-the-shelf artifacts. See this PR: #62

You are correct. I think #62 actually addresses this issue fully. We can close when that's merged.

@aetter
Copy link
Contributor

aetter commented Jul 9, 2021

#62

@aetter aetter closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.0.0 xx-documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants