Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] [ml-commons] add new model config parameters #2566

Closed
1 of 4 tasks
ylwu-amzn opened this issue Feb 1, 2023 · 0 comments · Fixed by #3456
Closed
1 of 4 tasks

[DOC] [ml-commons] add new model config parameters #2566

ylwu-amzn opened this issue Feb 1, 2023 · 0 comments · Fixed by #3456
Assignees
Labels
2 - In progress Issue/PR: The issue or PR is in progress. Machine Learning v2.5.0 'Issues and PRs related to version v2.5.0'

Comments

@ylwu-amzn
Copy link
Contributor

ylwu-amzn commented Feb 1, 2023

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.

We add two new model parameters in 2.5 which not included in this doc https://opensearch.org/docs/latest/ml-commons-plugin/model-serving-framework/#the-model_config-object.

  • "pooling_mode": type "string", If user trace model with Huggingface transformer, they may need to specify how to post-process model output by specifying "pooling_mode" and "normalize_result". Supported pooling method: mean, mean_sqrt_len, max, weightedmean, cls. For example, this huggingface model https://huggingface.co/sentence-transformers/all-MiniLM-L6-v2 uses mean pooling mode.
  • "normalize_result": type "boolean". If user trace model with Huggingface transformer, they may need to specify how to post-process model output by specifying "pooling_mode" and "normalize_result". For example, this huggingface model https://huggingface.co/sentence-transformers/all-MiniLM-L6-v2 needs to normalize result, so need to set "normalize_result" as `true.

You can also read this doc for more details https://github.com/opensearch-project/ml-commons/blob/2.x/docs/model_serving_framework/text_embedding_model_examples.md,

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

@Naarcha-AWS Naarcha-AWS added 1 - Backlog Issue: The issue is unassigned or assigned but not started and removed untriaged labels Feb 2, 2023
@Naarcha-AWS Naarcha-AWS self-assigned this Feb 2, 2023
@Naarcha-AWS Naarcha-AWS added the v2.5.0 'Issues and PRs related to version v2.5.0' label Feb 3, 2023
@Naarcha-AWS Naarcha-AWS added 2 - In progress Issue/PR: The issue or PR is in progress. and removed 1 - Backlog Issue: The issue is unassigned or assigned but not started labels Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In progress Issue/PR: The issue or PR is in progress. Machine Learning v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants