Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard with OSD multiple data source feature #119

Open
zhongnansu opened this issue Oct 14, 2022 · 1 comment
Open

Onboard with OSD multiple data source feature #119

zhongnansu opened this issue Oct 14, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@zhongnansu
Copy link
Member

When OSD MD feature is enabled. All visualizations in native OSD will support its use case. User experience side, there shouldn't be a difference for them. Since gantchart is also a visualization. Could you evaluate the changes of user experience?

For integrating with MD feature. We have provided API to be able to get a data source client instead of the default legacy client in gantchart. Logically, all places that interacts with OS will need to switch to use datasource client on demand. Since I am not familiar with the code base, I only found 1 places that does the actual search. Am I missing anything?

https://github.com/opensearch-project/dashboards-visualizations/blob/main/gantt-chart/server/routes/index.ts#L42

@joshuali925
Copy link
Member

Gantt chart uses IAggConfigs to get fields and context.core.opensearch.legacy.client.callAsCurrentUser() to send search requests

If user selects an index pattern from a different data source, I'm assuming IAggConfigs would have its metadata? It's used here

const fieldOptions = aggs.indexPattern.fields.map((field: Field) => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants