Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Search Comparison Tool should report query execution errors #262

Closed
smacrakis opened this issue Aug 16, 2023 · 0 comments
Closed

[BUG] Search Comparison Tool should report query execution errors #262

smacrakis opened this issue Aug 16, 2023 · 0 comments
Assignees
Labels
bug Something isn't working v2.11.0

Comments

@smacrakis
Copy link

What is the bug?

Search Comparison Tool doesn't report an error when the DSL query results in an error.

How can one reproduce the bug?

Enter {"this":"is a bogus query"} as Query 1. Hit Search.
This displays "No results" under Result 1.
Under Dev Tools, this reports a parsing exception.

What is the expected behavior?

Result 1 should show that there was an error. This could be something as simple as "Query error" or it could show the JSON error report. No need to get fancier than that (e.g., to make it human-friendly).

What is your host/environment?

n/a

Do you have any screenshots?

Not needed.

Do you have any additional context?

@smacrakis smacrakis added bug Something isn't working untriaged labels Aug 16, 2023
@msfroh msfroh removed the untriaged label Aug 16, 2023
@msfroh msfroh moved this from 🆕 New to Now(This Quarter) in Search Project Board Aug 16, 2023
@sejli sejli self-assigned this Aug 22, 2023
@sejli sejli moved this from Now(This Quarter) to 🏗 In progress in Search Project Board Aug 28, 2023
@mingshl mingshl moved this from 🏗 In progress to 👀 In review in Search Project Board Aug 29, 2023
@macohen macohen added the v2.11.0 label Sep 5, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Search Project Board Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.11.0
Projects
Archived in project
Development

No branches or pull requests

5 participants