Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing zip for bwc tests #329

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

vmmusings
Copy link
Member

Signed-off-by: vamsi-amazon [email protected]

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #329 (c6b8497) into main (9c01dfc) will decrease coverage by 2.51%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #329      +/-   ##
============================================
- Coverage     76.69%   74.18%   -2.52%     
- Complexity        0      383     +383     
============================================
  Files            30       94      +64     
  Lines          1905     3966    +2061     
  Branches        410      639     +229     
============================================
+ Hits           1461     2942    +1481     
- Misses          441      890     +449     
- Partials          3      134     +131     
Flag Coverage Δ
dashboards-reports 76.69% <ø> (ø)
reports-scheduler 71.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...heduler/model/UpdateReportInstanceStatusRequest.kt 67.44% <0.00%> (ø)
...portsscheduler/model/ReportDefinitionDetailsDoc.kt 0.00% <0.00%> (ø)
...search/reportsscheduler/settings/PluginSettings.kt 78.33% <0.00%> (ø)
...rtsscheduler/model/OnDemandReportCreateResponse.kt 88.88% <0.00%> (ø)
...sscheduler/model/CreateReportDefinitionResponse.kt 100.00% <0.00%> (ø)
...nsearch/reportsscheduler/metrics/BasicCounter.java 44.44% <0.00%> (ø)
...search/reportsscheduler/action/PluginBaseAction.kt 31.34% <0.00%> (ø)
...nsearch/reportsscheduler/model/ReportDefinition.kt 67.34% <0.00%> (ø)
...rtsscheduler/action/InContextReportCreateAction.kt 100.00% <0.00%> (ø)
...reportsscheduler/model/GetReportInstanceRequest.kt 92.85% <0.00%> (ø)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c01dfc...c6b8497. Read the comment docs.

@vmmusings vmmusings marked this pull request as ready for review April 4, 2022 20:40
@vmmusings vmmusings requested a review from a team as a code owner April 4, 2022 20:40
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmmusings vmmusings merged commit 1ee8ef2 into opensearch-project:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants