Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build version qualifier for reports-scheduler #322

Merged
merged 5 commits into from
Mar 30, 2022

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Mar 25, 2022

Signed-off-by: Joshua Li [email protected]

Description

Support build version qualifier for reports-scheduler

Issues Resolved

#306

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 requested a review from a team as a code owner March 25, 2022 23:30
@codecov-commenter
Copy link

Codecov Report

Merging #322 (e71bfc5) into main (a3adae8) will increase coverage by 4.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #322      +/-   ##
============================================
+ Coverage     72.64%   76.69%   +4.04%     
============================================
  Files            94       30      -64     
  Lines          3963     1905    -2058     
  Branches        644      410     -234     
============================================
- Hits           2879     1461    -1418     
+ Misses          909      441     -468     
+ Partials        175        3     -172     
Flag Coverage Δ
dashboards-reports 76.69% <ø> (ø)
reports-scheduler ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tsscheduler/model/CreateReportDefinitionRequest.kt
...tsscheduler/scheduler/ReportDefinitionJobRunner.kt
...search/reportsscheduler/action/PluginBaseAction.kt
...tsscheduler/action/UpdateReportDefinitionAction.kt
...rtsscheduler/action/InContextReportCreateAction.kt
...tsscheduler/action/DeleteReportDefinitionAction.kt
...tsscheduler/model/UpdateReportDefinitionRequest.kt
...search/reportsscheduler/settings/PluginSettings.kt
...tsscheduler/model/InContextReportCreateResponse.kt
...h/reportsscheduler/index/ReportDefinitionsIndex.kt
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3adae8...e71bfc5. Read the comment docs.

kavithacm
kavithacm previously approved these changes Mar 28, 2022
Signed-off-by: Joshua Li <[email protected]>
This reverts commit 8749c74.

Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Copy link
Member

@vmmusings vmmusings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuali925 joshuali925 merged commit 488e9d1 into opensearch-project:main Mar 30, 2022
kavilla pushed a commit to kavilla/dashboards-reports that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants