From 49d813cfb4a5587ce2224c74fc4226f2a5c43991 Mon Sep 17 00:00:00 2001
From: "opensearch-trigger-bot[bot]"
 <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Date: Mon, 30 Sep 2024 14:28:24 -0400
Subject: [PATCH] [navigation]feat: update category to flatten menus in
 analytics(all) use case (#448) (#456)

* feat: update category



* Bump upload artifact version



---------




(cherry picked from commit f50ed4cf788c37b5a19eb88f32b8b6e07a5bcda1)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Derek Ho <dxho@amazon.com>
---
 .github/workflows/cypress-e2e-reporting-test.yml         | 4 ++--
 .../dashboards-reports-test-and-build-workflow.yml       | 6 +++---
 .github/workflows/ftr-e2e-reporting-test.yml             | 4 ++--
 public/plugin_nav.tsx                                    | 9 ++++++++-
 4 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/cypress-e2e-reporting-test.yml b/.github/workflows/cypress-e2e-reporting-test.yml
index 35d51b64..4dce975e 100644
--- a/.github/workflows/cypress-e2e-reporting-test.yml
+++ b/.github/workflows/cypress-e2e-reporting-test.yml
@@ -154,14 +154,14 @@ jobs:
         working-directory: OpenSearch-Dashboards/plugins/${{ env.PLUGIN_NAME }}
 
       - name: Capture failure screenshots
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4.4.0
         if: failure()
         with:
           name: cypress-screenshots-${{ matrix.os }}
           path: OpenSearch-Dashboards/plugins/${{ env.PLUGIN_NAME }}/.cypress/screenshots
 
       - name: Capture test video
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4.4.0
         if: failure()
         with:
           name: cypress-videos-${{ matrix.os }}
diff --git a/.github/workflows/dashboards-reports-test-and-build-workflow.yml b/.github/workflows/dashboards-reports-test-and-build-workflow.yml
index 046add6b..96f1f9a0 100644
--- a/.github/workflows/dashboards-reports-test-and-build-workflow.yml
+++ b/.github/workflows/dashboards-reports-test-and-build-workflow.yml
@@ -66,7 +66,7 @@ jobs:
                                whoami && yarn build && mv -v ./build/*.zip ./build/${{ env.ARTIFACT_NAME }}-${{ env.OPENSEARCH_PLUGIN_VERSION }}.zip"
 
       - name: Upload Artifact For Linux
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4.4.0
         with:
           name: dashboards-reports-linux
           path: ./OpenSearch-Dashboards/plugins/${{ env.PLUGIN_NAME }}/build/${{ env.ARTIFACT_NAME }}-${{ env.OPENSEARCH_PLUGIN_VERSION }}.zip
@@ -128,7 +128,7 @@ jobs:
           mv ./build/*.zip ./build/${{ env.ARTIFACT_NAME }}-${{ env.OPENSEARCH_PLUGIN_VERSION }}.zip
 
       - name: Upload Artifact For Windows
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4.4.0
         with:
           name: dashboards-reports-windows
           path: ./build/${{ env.ARTIFACT_NAME }}-${{ env.OPENSEARCH_PLUGIN_VERSION }}.zip
@@ -185,7 +185,7 @@ jobs:
           mv ./build/*.zip ./build/${{ env.ARTIFACT_NAME }}-${{ env.OPENSEARCH_PLUGIN_VERSION }}.zip
 
       - name: Upload Artifact For MacOS
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4.4.0
         with:
           name: dashboards-reports-macosx
           path: ./build/${{ env.ARTIFACT_NAME }}-${{ env.OPENSEARCH_PLUGIN_VERSION }}.zip
diff --git a/.github/workflows/ftr-e2e-reporting-test.yml b/.github/workflows/ftr-e2e-reporting-test.yml
index 63a1f4a0..970457de 100644
--- a/.github/workflows/ftr-e2e-reporting-test.yml
+++ b/.github/workflows/ftr-e2e-reporting-test.yml
@@ -162,14 +162,14 @@ jobs:
         working-directory: opensearch-dashboards-functional-test
 
       - name: Capture failure screenshots
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4.4.0
         if: failure()
         with:
           name: cypress-screenshots-${{ matrix.os }}
           path: opensearch-dashboards-functional-test/cypress/screenshots
 
       - name: Capture test video
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4.4.0
         if: failure()
         with:
           name: cypress-videos-${{ matrix.os }}
diff --git a/public/plugin_nav.tsx b/public/plugin_nav.tsx
index df1f3b57..7f6f8bc6 100644
--- a/public/plugin_nav.tsx
+++ b/public/plugin_nav.tsx
@@ -26,7 +26,14 @@ export function registerAllPluginNavGroups(core: CoreSetup<ReportsDashboardsPlug
   core.chrome.navGroup.addNavLinksToGroup(DEFAULT_NAV_GROUPS.search, [
     {
       id: PLUGIN_ID,
-      category: DEFAULT_APP_CATEGORIES.analyzeSearch,
+      category: DEFAULT_APP_CATEGORIES.visualizeAndReport,
+      order: 300,
+    },
+  ]);
+  core.chrome.navGroup.addNavLinksToGroup(DEFAULT_NAV_GROUPS.all, [
+    {
+      id: PLUGIN_ID,
+      category: DEFAULT_APP_CATEGORIES.visualizeAndReport,
       order: 300,
     },
   ]);