Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Explorer Tab Removal #973

Closed
mengweieric opened this issue Sep 6, 2023 · 0 comments · Fixed by #970
Closed

[FEATURE] Explorer Tab Removal #973

mengweieric opened this issue Sep 6, 2023 · 0 comments · Fixed by #970
Assignees
@mengweieric
Labels
enhancement New feature or request

Comments

@mengweieric
Copy link
Collaborator

mengweieric commented Sep 6, 2023 •
edited
Loading

Is your feature request related to a problem?
Currently Observability log explorer has tab system that doesn't match the data explorer design.

What solution would you like?
Top level tab will be removed following a 2 step removal campaign

  1. Make minimal changes to instead having a dynamic generate tab, add a fix tab name for existing code base that is expecting a tabId to be passed to not break
  2. Remove and change code else where for asking a tabId to be passed

Before:
Screenshot 2023-09-06 at 10 55 53 AM
After:
The tab and 'add new' UIs will be removed.
@mengweieric mengweieric added enhancement New feature or request untriaged and removed untriaged labels Sep 6, 2023
@mengweieric mengweieric self-assigned this Sep 6, 2023
@mengweieric mengweieric linked a pull request Sep 6, 2023 that will close this issue
[Log Explorer] Remove top level tabs #970
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mengweieric mengweieric

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Log Explorer] Remove top level tabs mengweieric/dashboards-observability
1 participant
@mengweieric