Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline MAINTAINERS, CODEOWNERS and external collaborator permissions #35

Closed
Tracked by #125
dblock opened this issue Feb 14, 2023 · 6 comments
Closed
Tracked by #125
Assignees
Labels
bug Something isn't working

Comments

@dblock
Copy link
Member

dblock commented Feb 14, 2023

Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.

@Flyingliuhub
Copy link
Member

all set.

@dblock
Copy link
Member Author

dblock commented Mar 2, 2023

I don't believe the org "Admin" group has admin rights on this repo. Can you please add it?

@Flyingliuhub
Copy link
Member

I don't believe the org "Admin" group has admin rights on this repo. Can you please add it?
Thanks @dblock , I just added it.

@dblock
Copy link
Member Author

dblock commented Mar 2, 2023

  • dashboards-anywhere-team-maintainers shouldn't exist, the folks that are maintainers should be explicitly added with Maintain access
  • peterzhuamazon should not be Admin
  • dashboards-anywhere-contributor should not exist, only maintainers should have r/w merge access

@dblock dblock reopened this Mar 2, 2023
@seraphjiang
Copy link
Member

@dblock
dashboards-anywhere-contributor mapping to CODEOWNERS

what permission should code owner has? could we use team to organize and manage?

@dblock
Copy link
Member Author

dblock commented Mar 2, 2023

We synced it.

Screenshot 2023-03-02 at 6 43 23 PM

@dblock dblock closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants