Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace checked-in ZIPs with dynamic dependencies #335

Closed
Tracked by #1750
dblock opened this issue Mar 14, 2022 · 3 comments
Closed
Tracked by #1750

Replace checked-in ZIPs with dynamic dependencies #335

dblock opened this issue Mar 14, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request v2.0.0

Comments

@dblock
Copy link
Member

dblock commented Mar 14, 2022

Coming from opensearch-project/opensearch-build#1750, replace checked in zip with a dynamic dependency.

./cross-cluster-replication/src/test/resources/replication/opensearch-cross-cluster-replication-1.1.0.0.zip
@naveenpajjuri
Copy link
Contributor

naveenpajjuri commented Apr 8, 2022

@dblock We are dependent on CCR Artifacts to be published to Maven for us to use it as a dynamic dependency.
Unlike other plugins we don't have Artifacts published to cloudfront (in Odfe).
So we can only pick this issue after our Artifacts are there on Maven, so deferring this from 2.0

@naveenpajjuri
Copy link
Contributor

removing 2.0 tag from this issue, as there is a dependency (as per my previous comment).

@dblock
Copy link
Member Author

dblock commented Apr 18, 2022

Thanks for removing the ZIP in #366, @naveenpajjuri in favor of a dynamic download of the latest version. That was the right thing to do (comments above say otherwise).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.0.0
Projects
None yet
Development

No branches or pull requests

3 participants