Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fixing DataSources Parsing Errors (#678) #681

Merged
merged 2 commits into from
Jun 12, 2024
Merged

[Backport 2.x] Fixing DataSources Parsing Errors (#678) #681

merged 2 commits into from
Jun 12, 2024

Conversation

toepkerd
Copy link
Contributor

  • attempt to fix DataSources breaking change

Signed-off-by: Dennis Toepker [email protected]

  • adding default comments index values instead of passing null into constructor

Signed-off-by: Dennis Toepker [email protected]


Signed-off-by: Dennis Toepker [email protected]
Co-authored-by: Dennis Toepker [email protected]
(cherry picked from commit f4b2e1b)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* attempt to fix DataSources breaking change

Signed-off-by: Dennis Toepker <[email protected]>

* adding default comments index values instead of passing null into constructor

Signed-off-by: Dennis Toepker <[email protected]>

---------

Signed-off-by: Dennis Toepker <[email protected]>
Co-authored-by: Dennis Toepker <[email protected]>
(cherry picked from commit f4b2e1b)
@AWSHurneyt AWSHurneyt changed the title Fixing DataSources Parsing Errors (#678) [Backport 2.x] Fixing DataSources Parsing Errors (#678) Jun 12, 2024
@toepkerd toepkerd marked this pull request as ready for review June 12, 2024 00:20
@riysaxen-amzn riysaxen-amzn merged commit dd9fdf1 into opensearch-project:2.x Jun 12, 2024
9 checks passed
@toepkerd toepkerd deleted the backport-678-to-2.x branch June 12, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants