Adding EntityType to Comment Model #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
toepkerd
requested review from
lezzago,
bowenlan-amzn,
rishabhmaurya,
getsaurabh02,
eirsep,
sbcd90,
AWSHurneyt,
engechas,
riysaxen-amzn and
jowg-amazon
as code owners
eirsep
reviewed
Jun 10, 2024
| content = content, | ||
| createdTime = createdTime, | ||
| lastUpdatedTime = null, | ||
| user = user | ||
| ) | ||
|
|
||
| enum class EntityType(val value: String) { |
There was a problem hiding this comment.
if we intend for comments to be used by other plugins we shouldn't declared EntityType as an Enum as XYZPlugin might not accept "Alert" as a valid enum and Alerting plugin might not accept XYZ as an entity type so the enum is just overloaded and would end up causing more validations in each plugin irrespective of its presence here
… strings Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
AWSHurneyt
previously approved these changes
Jun 11, 2024
sbcd90
reviewed
Jun 11, 2024
| @@ -19,16 +19,17 @@ import java.time.Instant | |||
| data class Comment( | |||
| val id: String = NO_ID, | |||
There was a problem hiding this comment.
could you add Writeable & XContent tests for comment model?
https://github.com/opensearch-project/common-utils/blob/main/src/test/kotlin/org/opensearch/commons/alerting/model/WriteableTests.kt
https://github.com/opensearch-project/common-utils/blob/main/src/test/kotlin/org/opensearch/commons/alerting/model/XContentTests.kt
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
|
CIs blocked because job runners are unavailable, local build output: |
AWSHurneyt
approved these changes
Jun 11, 2024
riysaxen-amzn
approved these changes
Jun 11, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/common-utils/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/common-utils/backport-2.x
# Create a new branch
git switch --create backport-671-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 573cbf2241c1ccc018818b5940e141e6065d827e
# Push it to GitHub
git push --set-upstream origin backport-671-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/common-utils/backport-2.xThen, create a pull request where the |
5 tasks
AWSHurneyt
pushed a commit
that referenced
this pull request
Jun 12, 2024
* adding entityType to Comment model * updated tests * removing EntityType enum class, entity type in documents will just be strings * fixed unit tests * adding tests and release notes * moved comment test to WriteableTests * updated writeable test --------- Signed-off-by: Dennis Toepker <[email protected]> Co-authored-by: Dennis Toepker <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
* adding entityType to Comment model * updated tests * removing EntityType enum class, entity type in documents will just be strings * fixed unit tests * adding tests and release notes * moved comment test to WriteableTests * updated writeable test --------- Signed-off-by: Dennis Toepker <[email protected]> Co-authored-by: Dennis Toepker <[email protected]> (cherry picked from commit 841fd4d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Jun 12, 2024
* adding entityType to Comment model * updated tests * removing EntityType enum class, entity type in documents will just be strings * fixed unit tests * adding tests and release notes * moved comment test to WriteableTests * updated writeable test --------- (cherry picked from commit 841fd4d) Signed-off-by: Dennis Toepker <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Dennis Toepker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an extension to the following PR: #663
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.