Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Adding feature direction rules #1374

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport 1a3b8c9 from #1358.

* add feature direction

Signed-off-by: Amit Galitzky <[email protected]>

* changed condition

Signed-off-by: Amit Galitzky <[email protected]>

---------

Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 1a3b8c9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 74.76636% with 27 lines in your changes missing coverage. Please review.

Project coverage is 80.12%. Comparing base (8bea041) to head (31f3f1d).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...in/java/org/opensearch/ad/model/AnomalyResult.java 72.22% 7 Missing and 8 partials ⚠️
...a/org/opensearch/ad/ml/IgnoreSimilarExtractor.java 33.33% 1 Missing and 3 partials ⚠️
...c/main/java/org/opensearch/ad/model/Condition.java 73.33% 0 Missing and 4 partials ⚠️
.../java/org/opensearch/ad/ml/ThresholdingResult.java 75.00% 0 Missing and 1 partial ⚠️
.../java/org/opensearch/ad/model/AnomalyDetector.java 80.00% 0 Missing and 1 partial ⚠️
...opensearch/ad/transport/AnomalyResultResponse.java 80.00% 0 Missing and 1 partial ⚠️
...rch/forecast/transport/ForecastResultResponse.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1374      +/-   ##
============================================
- Coverage     80.14%   80.12%   -0.03%     
- Complexity     5684     5708      +24     
============================================
  Files           533      533              
  Lines         23435    23524      +89     
  Branches       2334     2367      +33     
============================================
+ Hits          18783    18848      +65     
- Misses         3550     3553       +3     
- Partials       1102     1123      +21     
Flag Coverage Δ
plugin 80.12% <74.76%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...in/java/org/opensearch/ad/model/ThresholdType.java 90.90% <100.00%> (+2.02%) ⬆️
...arch/timeseries/ExecuteResultResponseRecorder.java 77.77% <ø> (-1.49%) ⬇️
.../java/org/opensearch/timeseries/model/Feature.java 96.72% <100.00%> (+0.35%) ⬆️
...a/org/opensearch/timeseries/model/FeatureData.java 100.00% <100.00%> (ø)
...timeseries/rest/handler/IndexJobActionHandler.java 89.27% <100.00%> (ø)
...pensearch/timeseries/transport/ResultResponse.java 100.00% <ø> (ø)
.../java/org/opensearch/ad/ml/ThresholdingResult.java 84.33% <75.00%> (-0.48%) ⬇️
.../java/org/opensearch/ad/model/AnomalyDetector.java 88.85% <80.00%> (-0.14%) ⬇️
...opensearch/ad/transport/AnomalyResultResponse.java 75.93% <80.00%> (+0.15%) ⬆️
...rch/forecast/transport/ForecastResultResponse.java 16.88% <0.00%> (-0.23%) ⬇️
... and 3 more

... and 10 files with indirect coverage changes

@amitgalitz amitgalitz merged commit c95c430 into 2.x Nov 27, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant