Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download certs from security plugin instead of having a local copy #1360

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Nov 5, 2024

Description

Download certs from security repo instead of having a local copy in this repo.

Testing out this same pattern that the sql plugin uses to reduce copies of the demo certs across plugin repos.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-trigger-bot opensearch-trigger-bot bot added infra Changes to infrastructure, testing, CI/CD, pipelines, etc. backport 2.x labels Nov 5, 2024
Signed-off-by: Craig Perkins <[email protected]>
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.06%. Comparing base (f62885a) to head (a406de9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1360   +/-   ##
=========================================
  Coverage     80.05%   80.06%           
- Complexity     5669     5672    +3     
=========================================
  Files           533      533           
  Lines         23430    23430           
  Branches       2334     2334           
=========================================
+ Hits          18758    18760    +2     
- Misses         3562     3563    +1     
+ Partials       1110     1107    -3     
Flag Coverage Δ
plugin 80.06% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x infra Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant