From f06b00751209fcb2b1c45aca9d0e83a88dff9398 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Romain=20Tarti=C3=A8re?= Date: Mon, 7 Aug 2023 12:06:15 -1000 Subject: [PATCH] Fix display of detector names MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When starting or stopping detectors, the pop-up window shows the detector names as `DETECTOR_NAME />` where "DETECTOR_NAME" is the name of the detector. The markup seems to have residual `/>` that are rendered to the user. Remove them to ensure they do not appear between the opening and the closing EuiLink tags. Signed-off-by: Romain Tartière --- .../containers/ConfirmActionModals/utils/helpers.tsx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/public/pages/DetectorsList/containers/ConfirmActionModals/utils/helpers.tsx b/public/pages/DetectorsList/containers/ConfirmActionModals/utils/helpers.tsx index 6bc78193..55a2a0a5 100644 --- a/public/pages/DetectorsList/containers/ConfirmActionModals/utils/helpers.tsx +++ b/public/pages/DetectorsList/containers/ConfirmActionModals/utils/helpers.tsx @@ -27,7 +27,7 @@ const getNames = (detectors: DetectorListItem[]) => { href={`${PLUGIN_NAME}#/detectors/${detectors[i].id}`} target="_blank" > - {detectors[i].name} /> + {detectors[i].name} ), }); @@ -49,7 +49,7 @@ const getNamesAndMonitors = ( href={`${PLUGIN_NAME}#/detectors/${detectors[i].id}`} target="_blank" > - {detectors[i].name} /> + {detectors[i].name} ), Monitor: ( @@ -57,7 +57,7 @@ const getNamesAndMonitors = ( href={`${getAlertingMonitorListLink()}/${relatedMonitor.id}`} target="_blank" > - {relatedMonitor.name} /> + {relatedMonitor.name} ), }); @@ -68,7 +68,7 @@ const getNamesAndMonitors = ( href={`${PLUGIN_NAME}#/detectors/${detectors[i].id}`} target="_blank" > - {detectors[i].name} /> + {detectors[i].name} ), Monitor: '-', @@ -95,7 +95,7 @@ const getNamesAndMonitorsAndStates = ( href={`${PLUGIN_NAME}#/detectors/${detectors[i].id}`} target="_blank" > - {detectors[i].name} /> + {detectors[i].name} ), Monitor: ( @@ -103,7 +103,7 @@ const getNamesAndMonitorsAndStates = ( href={`${getAlertingMonitorListLink()}/${relatedMonitor.id}`} target="_blank" > - {relatedMonitor.name} /> + {relatedMonitor.name} ), Running: {isRunning ? 'Yes' : 'No'},