Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #793

Closed
Tracked by #125
dblock opened this issue Feb 14, 2023 · 4 comments · Fixed by #911
Closed
Tracked by #125

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #793

dblock opened this issue Feb 14, 2023 · 4 comments · Fixed by #911
Assignees
@lezzago
Labels
untriaged

Comments

@dblock
Copy link
Member

dblock commented Feb 14, 2023

Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.
@dblock dblock mentioned this issue Feb 14, 2023
Closed
87 tasks
@lezzago lezzago removed the untriaged label Feb 17, 2023
@lezzago lezzago self-assigned this Feb 23, 2023
@lezzago lezzago mentioned this issue Feb 24, 2023
Merged
@bbarani
Copy link
Member

bbarani commented May 2, 2023

Fixed the permissions. Closing this issue

@bbarani bbarani closed this as completed May 2, 2023
@bbarani bbarani reopened this May 2, 2023
@bbarani
Copy link
Member

bbarani commented May 2, 2023 •
edited
Loading

I just realized that the CODEOWNERS file doesn't include all the users listed on Maintainers file. @lezzago Can you please add the Github id's of all maintainers in CODEOWNERS file and close this issue when its green?

@lezzago lezzago mentioned this issue May 3, 2023
Merged
@lezzago lezzago closed this as completed May 10, 2023
@bbarani
Copy link
Member

bbarani commented May 10, 2023

Re-opening this issue as the CODEOWNERS and MAINTAINERS list doesn't match.

@bbarani bbarani reopened this May 10, 2023
@bbarani bbarani mentioned this issue May 10, 2023
Merged
@dblock
Copy link
Member Author

dblock commented May 10, 2023

Verified permissions, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lezzago lezzago

Labels
untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating the CODEOWNERS file with the right format bbarani/alerting
3 participants
@dblock @lezzago @bbarani