Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] MonitorHistory timeline bars don't resize automatically when opening a flyout. #253

Open
AWSHurneyt opened this issue May 25, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@AWSHurneyt
Copy link
Collaborator

What is the bug?
This timeline bar graphics in the History component of the Monitor details page do not resize automatically when opening a flyout.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Go to the Monitor details page for a document level monitor that has alerts.
  2. Click on the Document link for one of the alerts to open its flyout.
  3. See error

What is the expected behavior?
All elements in the graphic should resize automatically when opening and closing the flyout.

What is your host/environment?

  • OS: iOS
  • Version 10.15.7
  • Plugins: alerting, alertingDashboards

Do you have any screenshots?
Screen Shot 2022-05-25 at 4 44 15 PM

Do you have any additional context?
Dragging the edge of the window to resize the browser will resize the History element appropriately.

@AWSHurneyt AWSHurneyt added bug Something isn't working untriaged labels May 25, 2022
@AWSHurneyt
Copy link
Collaborator Author

A similar bug can be seen on the Monitors tab when browser inspect side panel is open.
Screen Shot 2022-06-13 at 2 02 14 PM

@amsiglan
Copy link
Collaborator

Findings:

  1. The visualization depends on the resize event to change its width.

    • A possible solution is to raise the resize event but that might lead some extra handlers to run as well. Another way out is to avoid using pushOver flyout similar to what we do in other plugins like security analytics.
  2. The monitor table issue happens because of static widths specified for the columns in tableUtils

    • We need to review why these were added in first place and see if we can remove them.

@amsiglan amsiglan self-assigned this Nov 29, 2022
@AWSHurneyt
Copy link
Collaborator Author

Related issue #296

@amsiglan
Copy link
Collaborator

amsiglan commented Dec 6, 2022

The first half of the bug won't show up now as the Flyouts are using Overlay type instead of pushover.
For the second half, let me send a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants