[Feature/Identity] Fixes test failures in gradle check for #4798

[DarshitChanpura]

Description

As a follow-up for #4798, this PR fixes test failures that were noticed in CI gradle check.

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7569/
• CommitID: fad340f
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7570/
• CommitID: e04e786
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7571/
• CommitID: 78c1306
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7680/
• CommitID: 50de65b
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7682/
• CommitID: ce38d69
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7684/
• CommitID: 57df6b6
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7699/
• CommitID: d49b703
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: ABORTED ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7711/
• CommitID: 0e91f95
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[DarshitChanpura]

Gradle check ran for a little above 2hrs and then was aborted. This is significantly higher than current main's build time which is 32mins 10secs for gradle check.

The likely culprit is the logout calls on every login resulting in added time. I'm working on finding a better solution than this.

OpenSearch/server/src/main/java/org/opensearch/rest/RestController.java

Lines 696 to 710 in 0e91f95

	private static void logoutCurrentSubjectAndClearSessionIfAny() {
	try {
	// logout current subject
	org.apache.shiro.subject.Subject subject = SecurityUtils.getSubject();
	if (subject == null) return;
	subject.logout();
	// Get current session and kill it before proceeding to create a new session
	// TODO: need to study the impact of this
	Session session = subject.getSession(false);
	if (session == null) return;
	session.stop();
	} catch (Exception e) {
	// Ignore all errors, as we're trying to silently kill the session
	}
	}

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.rest.RestControllerTests.testRestRequestAuthenticationFailure

• URL: https://build.ci.opensearch.org/job/gradle-check/7720/
• CommitID: 5d449c0
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov-commenter]

Codecov Report

Merging #5441 (dea9f34) into feature/identity (c39a92b) will increase coverage by 0.22%.
The diff coverage is 80.00%.

@@                  Coverage Diff                   @@
##             feature/identity    #5441      +/-   ##
======================================================
+ Coverage               70.86%   71.09%   +0.22%     
- Complexity              58405    58560     +155     
======================================================
  Files                    4769     4769              
  Lines                  278958   278962       +4     
  Branches                40300    40301       +1     
======================================================
+ Hits                   197681   198323     +642     
+ Misses                  65087    64457     -630     
+ Partials                16190    16182       -8     

Impacted Files	Coverage Δ
...in/java/org/opensearch/authn/noop/NoopSubject.java	60.00% <0.00%> (-6.67%)	⬇️
...g/opensearch/authn/AuthenticationTokenHandler.java	84.00% <100.00%> (ø)
...org/opensearch/authn/internal/InternalSubject.java	71.42% <100.00%> (+38.09%)	⬆️
...port/ResponseHandlerFailureTransportException.java	0.00% <0.00%> (-60.00%)	⬇️
...opensearch/persistent/PersistentTasksExecutor.java	22.22% <0.00%> (-44.45%)	⬇️
...rc/main/java/org/opensearch/ingest/IngestInfo.java	51.72% <0.00%> (-27.59%)	⬇️
.../java/org/opensearch/index/reindex/RemoteInfo.java	51.37% <0.00%> (-27.53%)	⬇️
...ava/org/opensearch/threadpool/ThreadPoolStats.java	58.66% <0.00%> (-22.67%)	⬇️
...nsearch/index/shard/IndexingOperationListener.java	65.57% <0.00%> (-21.32%)	⬇️
...main/java/org/opensearch/ingest/ProcessorInfo.java	47.36% <0.00%> (-21.06%)	⬇️
... and 484 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[DarshitChanpura]

Follow-up: Add tests for isAuthenticated(), logout() and verifying number of calls to login() method

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.indices.stats.IndexStatsIT.testFilterCacheStats

• URL: https://build.ci.opensearch.org/job/gradle-check/7721/
• CommitID: d4cf808
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/7722/
• CommitID: 5db6f1b

[DarshitChanpura]

Follow-up: Add tests for isAuthenticated(), logout() and verifying number of calls to login() method

Done.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/7725/
• CommitID: 22880f2

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8812/
• CommitID: 3153ba7
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[DarshitChanpura]

@peternied This change might not be needed at all if we were to discard the check of whether user is currently logged in and whether the new request is by same user, because CI for latest commit c39a92b in feature/identity is passing

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8825/
• CommitID: 9ec3597
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/8828/
• CommitID: dea9f34

[peternied]

@peternied This change might not be needed at all if we were to discard the check of whether user is currently logged in and whether the new request is by same user, because CI for latest commit c39a92b in feature/identity is passing

Being that CI is working I'd say maybe its better to close this out as unneeded - thanks for digging in!