Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Identity] Bearer auth via internal idp #5367

Conversation

stephen-crawford
Copy link
Contributor

Description

This PR introduces bearer authentication with JWTs for feature/identity. It includes the changes introduced in #4798 because the authentication uses the same token management system to operate. There are included unit tests for bearer authentication which check catching early JWTs, expired JWTs, and valid JWTs. It is not clear what an invalid JWT would be if it were not early or expired.

There are also adaptations of the basic auth integration tests.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cwperks and others added 30 commits November 9, 2022 14:40
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
…led by Internal Realm

Signed-off-by: Darshit Chanpura <[email protected]>
…wrapping for authentication

Signed-off-by: Darshit Chanpura <[email protected]>
…e in case of missing auth credentials

Signed-off-by: Darshit Chanpura <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Stephen Crawford <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Stephen Crawford <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
@stephen-crawford stephen-crawford marked this pull request as ready for review November 30, 2022 15:05
@stephen-crawford stephen-crawford requested review from a team and reta as code owners November 30, 2022 15:05
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@stephen-crawford
Copy link
Contributor Author

@DarshitChanpura @cwperks @peternied I am opening this for some feedback. The gradle check is still failing because it says a license is missing for a jar file. I am not sure what the fix for that is but if you have any ideas it would be appreciated!

The error is:

Execution failed for task ':server:dependencyLicenses'.
> Missing LICENSE for slf4j-api-1.7.36.jar, expected in slf4j-api-LICENSE.txt

@stephen-crawford stephen-crawford marked this pull request as draft November 30, 2022 17:18
@DarshitChanpura
Copy link
Member

@DarshitChanpura @cwperks @peternied I am opening this for some feedback. The gradle check is still failing because it says a license is missing for a jar file. I am not sure what the fix for that is but if you have any ideas it would be appreciated!

The error is:

Execution failed for task ':server:dependencyLicenses'.
> Missing LICENSE for slf4j-api-1.7.36.jar, expected in slf4j-api-LICENSE.txt

You can run ./gradlew updateShas to fix this

Signed-off-by: Stephen Crawford <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Stephen Crawford <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Gradle Check (Jenkins) Run Completed with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants