Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin] repository-azure is not working properly hangs on basic oper… #1749

Merged
merged 1 commit into from
Dec 16, 2021
Merged

[plugin] repository-azure is not working properly hangs on basic oper… #1749

merged 1 commit into from
Dec 16, 2021

Conversation

reta
Copy link
Collaborator

@reta reta commented Dec 16, 2021

Signed-off-by: Andriy Redko [email protected]

Description

Bringing #1745 to main

Issues Resolved

Closes #1734

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
[plugin] repository-azure is not working properly hangs on basic oper…
80a1070 
…ations (opensearch-project#1740)

* [plugin] repository-azure is not working properly hangs on basic operations

Signed-off-by: Andriy Redko <[email protected]>

* Added tests cases and TODO items, addressing code review comments

Signed-off-by: Andriy Redko <[email protected]>
@reta reta requested a review from a team as a code owner December 16, 2021 20:12
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 80a1070
Log 1544

Reports 1544

nknize
nknize approved these changes Dec 16, 2021
View reviewed changes
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a backport PR to 1.x as well. I didn't notice the first merge was to 1.2. This should've started in main w/ backport PRs to 1.x and 1.2 branches, respectively. Lets follow that flow in the future.

@nknize nknize added bug Something isn't working Plugins v2.0.0 Version 2.0.0 Severity-Critical Severity-Blocker pending backport Identifies an issue or PR that still needs to be backported and removed Severity-Critical labels Dec 16, 2021
@reta
Copy link
Collaborator Author

reta commented Dec 16, 2021 •
edited
Loading

Need a backport PR to 1.x as well. I didn't notice the first merge was to 1.2. This should've started in main w/ backport PRs to 1.x and 1.2 branches, respectively. Lets follow that flow in the future.

@nknize It is in 1.x and 1.2 already, sorry for confusion

@nknize
Copy link
Collaborator

nknize commented Dec 16, 2021

@nknize It is in 1.x and 1.2 already, sorry for confusion

👍 no worries! thx for working this.

@nknize nknize merged commit 20692a2 into opensearch-project:main Dec 16, 2021
@nknize nknize removed the pending backport Identifies an issue or PR that still needs to be backported label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Plugins Severity-Blocker v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] repository-azure plugin hangs in OpenSearch >= 1.2.0
4 participants
@reta @opensearch-ci-bot @nknize @dblock