Register UnmodifiableOnRestore settings #17121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AnnTian Shao <[email protected]>
anntians
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17121 +/- ##
============================================
- Coverage 72.30% 72.25% -0.06%
+ Complexity 65482 65398 -84
============================================
Files 5309 5309
Lines 304324 304350 +26
Branches 44132 44141 +9
============================================
- Hits 220056 219903 -153
- Misses 66259 66335 +76
- Partials 18009 18112 +103 ☔ View full report in Codecov by Sentry. |
|
This PR is more of a code refactor to register previously unregistered settings with |
jed326
reviewed
Jan 29, 2025
...r/src/internalClusterTest/java/org/opensearch/action/admin/indices/create/CreateIndexIT.java
Show resolved
Hide resolved
client/rest-high-level/src/test/java/org/opensearch/client/IndicesClientIT.java
Show resolved
Hide resolved
client/rest-high-level/src/test/java/org/opensearch/client/IndicesClientIT.java
Outdated
Show resolved
Hide resolved
sohami
reviewed
Jan 29, 2025
server/src/main/java/org/opensearch/cluster/metadata/IndexMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/settings/IndexScopedSettings.java
Show resolved
Hide resolved
anntians
force-pushed
the
finalRegisterSettings
branch
from
5734f23 to
d2a894e
Compare
Signed-off-by: AnnTian Shao <[email protected]>
anntians
force-pushed
the
finalRegisterSettings
branch
from
d2a894e to
d2b4139
Compare
sohami
reviewed
Jan 30, 2025
client/rest-high-level/src/test/java/org/opensearch/client/IndicesClientIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: AnnTian Shao <[email protected]>
jed326
reviewed
Jan 30, 2025
server/src/test/java/org/opensearch/index/IndexSettingsTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: AnnTian Shao <[email protected]>
|
❌ Gradle check result for 8576e43: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
jed326
approved these changes
Jan 30, 2025
sohami
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on another PR. In the other PR we added a new Setting property
UnmodifiableOnRestoreto prevent settings from being modified on restore, but we weren't able to add the property to several settings because they were not yet registered. So this PR registers those settings withUnmodifiableOnRestoreRelated Issues
Resolves Issue 2334 in KNN repository: opensearch-project/k-NN#2334
#17019
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.