-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JDK-23 (build time and runtime) #16257
Conversation
❌ Gradle check result for 1e6c67a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 1e6c67a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 1e6c67a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@reta Looks like you are iterating, LMK when you'd like a deeper look - fundamentally I approve! |
❌ Gradle check result for 070914c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ea1c382: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 5714c24: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 5714c24: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 5714c24: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
0270ad3
to
2d1efcb
Compare
❌ Gradle check result for 2d1efcb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Andriy Redko <[email protected]>
@peternied all set! thank you! |
The check is green but GA script is stuck:
|
❌ Gradle check result for e5ac86f: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for e5ac86f: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16257 +/- ##
============================================
- Coverage 72.06% 72.03% -0.04%
+ Complexity 64822 64804 -18
============================================
Files 5308 5308
Lines 302574 302565 -9
Branches 43710 43710
============================================
- Hits 218048 217945 -103
- Misses 66648 66735 +87
- Partials 17878 17885 +7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 1e7f6df) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Support JDK-23 (build time and runtime) (#16257) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 1e7f6df) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update DistroTestPlugin.java Signed-off-by: Andriy Redko <[email protected]> * Update version.properties Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <[email protected]>
Thanks for reviewing this @msfroh |
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
objenesis = 3.2 | ||
bytebuddy = 1.14.9 | ||
bytebuddy = 1.15.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reta Can we backport this version update change to 2.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me provide some context here. I'm working on the skills repo. I've created a PR to fix the CI error by bumping the version of bytebuddy
, but it is very strange that its backport-2.x PR meets with the version conflict error:
* What went wrong:
Execution failed for task ':compileTestJava'.
> Could not resolve all dependencies for configuration ':testCompileClasspath'.
> Conflict found for the following module:
- net.bytebuddy:byte-buddy between versions 1.15.10 and 1.15.4
Do you have any hint on why? I do not have much context on these dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2.x is on 15.10 as well (#16657), I will take a look shortly why the CI for the skills repo repo fails.
Description
Support JDK-23 (build time and runtime)
Related Issues
Part of #16255
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.