Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JDK-23 (build time and runtime) #16257

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

reta
Copy link
Collaborator

@reta reta commented Oct 9, 2024

Description

Support JDK-23 (build time and runtime)

Related Issues

Part of #16255

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta added backport 2.x Backport to 2.x branch skip-changelog labels Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for 1e6c67a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for 1e6c67a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for 1e6c67a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peternied
Copy link
Member

@reta Looks like you are iterating, LMK when you'd like a deeper look - fundamentally I approve!

Copy link
Contributor

❌ Gradle check result for 070914c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for ea1c382: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5714c24: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5714c24: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5714c24: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the issue-16255 branch 2 times, most recently from 0270ad3 to 2d1efcb Compare October 10, 2024 18:14
Copy link
Contributor

❌ Gradle check result for 2d1efcb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented Oct 10, 2024

@peternied all set! thank you!

@reta
Copy link
Collaborator Author

reta commented Oct 10, 2024

The check is green but GA script is stuck:

parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 1, column 10
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
Workflow running status :Attempt 1/10 failed. The jq processing failed with exit code: 4. Retrying...
Attempt 2/10 failed. The jq processing failed with exit code: 4. Retrying...
Attempt 3/10 failed. The jq processing failed with exit code: 4. Retrying...
Attempt 4/10 failed. The jq processing failed with exit code: 4. Retrying...
Attempt 5/10 failed. The jq processing failed with exit code: 4. Retrying...
Attempt 6/10 failed. The jq processing failed with exit code: 4. Retrying...
true
Complete the run, checking results now......
Use queue information to find build number in Jenkins if available
parse error: Invalid numeric literal at line 5, column 12
WORKFLOW_URL

Copy link
Contributor

❌ Gradle check result for e5ac86f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for e5ac86f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.03%. Comparing base (691f725) to head (e5ac86f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16257      +/-   ##
============================================
- Coverage     72.06%   72.03%   -0.04%     
+ Complexity    64822    64804      -18     
============================================
  Files          5308     5308              
  Lines        302574   302565       -9     
  Branches      43710    43710              
============================================
- Hits         218048   217945     -103     
- Misses        66648    66735      +87     
- Partials      17878    17885       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 1e7f6df into opensearch-project:main Oct 10, 2024
37 of 38 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2024
Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 1e7f6df)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta added a commit that referenced this pull request Oct 11, 2024
* Support JDK-23 (build time and runtime) (#16257)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 1e7f6df)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update DistroTestPlugin.java

Signed-off-by: Andriy Redko <[email protected]>

* Update version.properties

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andriy Redko <[email protected]>
@peternied
Copy link
Member

Thanks for reviewing this @msfroh

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
objenesis = 3.2
bytebuddy = 1.14.9
bytebuddy = 1.15.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reta Can we backport this version update change to 2.x?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me provide some context here. I'm working on the skills repo. I've created a PR to fix the CI error by bumping the version of bytebuddy, but it is very strange that its backport-2.x PR meets with the version conflict error:

* What went wrong:
Execution failed for task ':compileTestJava'.
> Could not resolve all dependencies for configuration ':testCompileClasspath'.
   > Conflict found for the following module:
       - net.bytebuddy:byte-buddy between versions 1.15.10 and 1.15.4

Do you have any hint on why? I do not have much context on these dependencies.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2.x is on 15.10 as well (#16657), I will take a look shortly why the CI for the skills repo repo fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants