Add default implementation to new finalizeSnapshot() in Repository #16128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sachin Kale <[email protected]>
sachinpkale
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 606b547: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
gbbafna
approved these changes
Sep 30, 2024
|
❌ Gradle check result for 606b547: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16128 +/- ##
============================================
- Coverage 72.00% 71.92% -0.09%
+ Complexity 64487 64460 -27
============================================
Files 5288 5288
Lines 301419 301424 +5
Branches 43549 43550 +1
============================================
- Hits 217026 216787 -239
- Misses 66587 66815 +228
- Partials 17806 17822 +16 ☔ View full report in Codecov by Sentry. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
…16128) Signed-off-by: Sachin Kale <[email protected]> (cherry picked from commit 9a5c7b2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 30, 2024
hainenber
pushed a commit
to hainenber/OpenSearch
that referenced
this pull request
Oct 1, 2024
…pensearch-project#16128) Signed-off-by: Sachin Kale <[email protected]>
reta
pushed a commit
that referenced
this pull request
Oct 3, 2024
…16128) Signed-off-by: Sachin Kale <[email protected]> (cherry picked from commit 9a5c7b2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
added a commit
that referenced
this pull request
Oct 3, 2024
…n Repository (#16141) * Add default implementation to new finalizeSnapshot() in Repository (#16128) Signed-off-by: Sachin Kale <[email protected]> (cherry picked from commit 9a5c7b2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix japicmp configuration by treating abstract-to-default method changes as non-breaking Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <[email protected]>
ruai0511
pushed a commit
to ruai0511/OpenSearch
that referenced
this pull request
Oct 4, 2024
…pensearch-project#16128) Signed-off-by: Sachin Kale <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…pensearch-project#16128) Signed-off-by: Sachin Kale <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…pensearch-project#16128) Signed-off-by: Sachin Kale <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…pensearch-project#16128) Signed-off-by: Sachin Kale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Repository.finalizeSnapshotCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.