-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Clone Index setting override for replication type #16076
base: main
Are you sure you want to change the base?
Fix Clone Index setting override for replication type #16076
Conversation
Signed-off-by: luyuncheng <[email protected]>
Signed-off-by: luyuncheng <[email protected]>
❌ Gradle check result for 2353b72: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java
Show resolved
Hide resolved
server/src/test/java/org/opensearch/cluster/metadata/MetadataCreateIndexServiceTests.java
Show resolved
Hide resolved
Signed-off-by: luyuncheng <[email protected]>
❌ Gradle check result for 81aec5e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
rest-api-spec/src/main/resources/rest-api-spec/test/indices.split/30_copy_settings.yml
Show resolved
Hide resolved
❌ Gradle check result for 81aec5e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: luyuncheng <[email protected]>
❌ Gradle check result for ba11329: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@luyuncheng thanks for your work, please resolve the conflicts and ensure all checks can pass. |
Signed-off-by: luyuncheng <[email protected]>
❌ Gradle check result for 9d342b3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: luyuncheng <[email protected]>
9d342b3
to
9e2205a
Compare
❌ Gradle check result for 9e2205a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: luyuncheng <[email protected]>
❌ Gradle check result for 1682001: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@luyuncheng you may need to add a |
there is some IT for Resize AND SegmentReplication do not consider resize with same replication type, let me fixed IT |
@gaobinlong there is #11583 can limited replication change explicit, but i do not see any merge settings for resize indices, resize would changed the replication implicit? and i will change this PR. also i think the yamlRest is also needed for #11583, |
@dreamer-89 , please help to confirm this, do we allow setting a replication type different from the source index for the resize operations?(when |
@mch2 and I were looking at Clone Index together a few weeks ago. If I recall correctly it (and the other similar operations) creates a whole new index. If you want the new index to use a different replication type, I don't think there's any technical reason why it wouldn't work, since the new index doesn't really have anything to do with the old index once it's created. |
Thanks @msfroh! Then I think we can keep only the tests code in this PR, convert it to a PR of adding more test cases for overriding replication type when resize, @luyuncheng would you like to this? |
This PR is stalled because it has been open for 30 days with no activity. |
Description
Related Issues
we see there is previous pr and issues, but when we do clone/shirnk/split which is
Resize Action
it would make a Segment Replication Type indices to Document Replication Type.#11417 @kotwanikunal
#11230
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.