Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clone Index setting override for replication type #16076

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

luyuncheng
Copy link
Contributor

Description

  • Fix index setting override for replication type clone/shrink/split indices

Related Issues

we see there is previous pr and issues, but when we do clone/shirnk/split which is Resize Action it would make a Segment Replication Type indices to Document Replication Type.

#11417 @kotwanikunal
#11230

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@luyuncheng luyuncheng changed the title FIX Clone Index setting override for replication type Fix Clone Index setting override for replication type Sep 25, 2024
Copy link
Contributor

❌ Gradle check result for 2353b72: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 81aec5e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gaobinlong gaobinlong added the backport 2.x Backport to 2.x branch label Sep 27, 2024
Copy link
Contributor

❌ Gradle check result for 81aec5e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for ba11329: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gaobinlong
Copy link
Collaborator

@luyuncheng thanks for your work, please resolve the conflicts and ensure all checks can pass.

Copy link
Contributor

❌ Gradle check result for 9d342b3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 9e2205a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: luyuncheng <[email protected]>
Copy link
Contributor

❌ Gradle check result for 1682001: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gaobinlong
Copy link
Collaborator

❌ Gradle check result for 1682001: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@luyuncheng you may need to add a skip version section to the yaml test file to make sure the yaml test can pass in a mixed version cluster.

@luyuncheng
Copy link
Contributor Author

❌ Gradle check result for 1682001: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@luyuncheng you may need to add a skip version section to the yaml test file to make sure the yaml test can pass in a mixed version cluster.

there is some IT for Resize AND SegmentReplication do not consider resize with same replication type, let me fixed IT

@luyuncheng
Copy link
Contributor Author

luyuncheng commented Sep 30, 2024

@gaobinlong there is #11583 can limited replication change explicit, but i do not see any merge settings for resize indices, resize would changed the replication implicit? and i will change this PR. also i think the yamlRest is also needed for #11583,

@gaobinlong
Copy link
Collaborator

@gaobinlong there is #11583 can limited replication change explicit, but i do not see any merge settings for resize indices, resize would changed the replication implicit? and i will change this PR. also i think the yamlRest is also needed for #11583,

@dreamer-89 , please help to confirm this, do we allow setting a replication type different from the source index for the resize operations?(when cluster.index.restrict.replication.type is false), thank you!

@msfroh
Copy link
Collaborator

msfroh commented Oct 9, 2024

@dreamer-89 , please help to confirm this, do we allow setting a replication type different from the source index for the resize operations?(when cluster.index.restrict.replication.type is false), thank you!

@mch2 and I were looking at Clone Index together a few weeks ago. If I recall correctly it (and the other similar operations) creates a whole new index.

If you want the new index to use a different replication type, I don't think there's any technical reason why it wouldn't work, since the new index doesn't really have anything to do with the old index once it's created.

@gaobinlong
Copy link
Collaborator

If you want the new index to use a different replication type, I don't think there's any technical reason why it wouldn't work, since the new index doesn't really have anything to do with the old index once it's created.

Thanks @msfroh! Then I think we can keep only the tests code in this PR, convert it to a PR of adding more test cases for overriding replication type when resize, @luyuncheng would you like to this?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch stalled Issues that have stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants