Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Provide factory for pluggable deciders #15729

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Gankris96
Copy link
Contributor

@Gankris96 Gankris96 commented Sep 5, 2024

Description

Backport of #15713

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for a239cb0: SUCCESS

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 3980f9e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 3980f9e: SUCCESS

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.74%. Comparing base (dcdc4d2) to head (8afd500).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...earch/deciders/ConcurrentSearchRequestDecider.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15729      +/-   ##
============================================
+ Coverage     71.55%   71.74%   +0.18%     
- Complexity    64312    64460     +148     
============================================
  Files          5262     5262              
  Lines        301279   301282       +3     
  Branches      43861    43861              
============================================
+ Hits         215574   216141     +567     
+ Misses        67703    67120     -583     
- Partials      18002    18021      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 4bf6f0e: SUCCESS

@jed326 jed326 added the v2.17.0 label Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❕ Gradle check result for 8afd500: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants